Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 954523003: Move sockets_* OWNERS files out of unexpected subdirectories. (Closed)

Created:
5 years, 10 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move sockets_* OWNERS files out of unexpected subdirectories. When these APIs were moved into //extensions the OWNERS files were accidentially placed into their own subdirectories. BUG= Committed: https://crrev.com/8cf9caa44a6c41ca1df13a6e764ad430deb26901 Cr-Commit-Position: refs/heads/master@{#317637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-3 lines, -0 lines) Patch
A + extensions/browser/api/sockets_tcp/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/browser/api/sockets_tcp/sockets_tcp/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A + extensions/browser/api/sockets_tcp_server/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/browser/api/sockets_tcp_server/sockets_tcp_server/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
A + extensions/browser/api/sockets_udp/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
D extensions/browser/api/sockets_udp/sockets_udp/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
Reilly Grant (use Gerrit)
Just a little cleanup.
5 years, 10 months ago (2015-02-23 19:16:46 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 10 months ago (2015-02-23 19:22:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954523003/1
5 years, 10 months ago (2015-02-23 19:24:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/61845)
5 years, 10 months ago (2015-02-23 19:27:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954523003/1
5 years, 10 months ago (2015-02-23 20:03:27 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-23 20:04:33 UTC) #10
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 20:05:22 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8cf9caa44a6c41ca1df13a6e764ad430deb26901
Cr-Commit-Position: refs/heads/master@{#317637}

Powered by Google App Engine
This is Rietveld 408576698