Issue 954513003: Wire in more-real stock data for stocks example.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954513003: Wire in more-real stock data for stocks example. (Closed)

Created:
5 years, 10 months ago by eseidel

Modified:
5 years, 10 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Wire in more-real stock data for stocks example. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d32aa663a4ff488e1455a443513b7bf162b74530

Patch Set 1 #

Total comments: 3

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3025 lines, -23 lines)			Patch
	A	sky/examples/stocks/companylist.sky	View		1 chunk	+3012 lines, -0 lines	3 comments	Download
	M	sky/examples/stocks/stocks.sky	View		3 chunks	+13 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/954513003/diff/1/sky/examples/stocks/companylist.sky File sky/examples/stocks/companylist.sky (right): https://codereview.chromium.org/954513003/diff/1/sky/examples/stocks/companylist.sky#newcode5 sky/examples/stocks/companylist.sky:5: final List<List<String>> companyList = [ s/companyList/_kCompanyList/ The _ ...

5 years, 10 months ago (2015-02-23 19:08:16 UTC) #2

eseidel

5 years, 10 months ago (2015-02-23 20:52:21 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d32aa663a4ff488e1455a443513b7bf162b74530 (presubmit successful).

Expand Messages | Collapse Messages