tools/telemetry/telemetry/benchmark.py - Issue 954503003: Fixed merge error in benchmark.py which removed the predicate variable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/benchmark.py

Issue 954503003: Fixed merge error in benchmark.py which removed the predicate variable. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed optparse module name Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/benchmark.py

diff --git a/tools/telemetry/telemetry/benchmark.py b/tools/telemetry/telemetry/benchmark.py

index 6a34ec204c51cc0ec0fc132a6167b96749b65e7f..f86393c4d2aa5ef8687fac121b2d694ecc2dc2a7 100644

--- a/tools/telemetry/telemetry/benchmark.py

+++ b/tools/telemetry/telemetry/benchmark.py

@@ -189,8 +189,9 @@ class Benchmark(command_line.Command):

self._DownloadGeneratedProfileArchive(finder_options)

benchmark_metadata = self.GetMetadata()

- with results_options.CreateResults(benchmark_metadata,

- finder_options) as results:

+ with results_options.CreateResults(

+ benchmark_metadata, finder_options,

+ self.ValueCanBeAddedPredicate) as results:

try:

user_story_runner.Run(pt, us, expectations, finder_options, results,

max_failures=self._max_failures)

« no previous file with comments | « no previous file | tools/telemetry/telemetry/benchmark_unittest.py » ('j') | no next file with comments »