Issue 954493002: Revert "Avoid printing braces for one-statement blocks in js-printer."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954493002: Revert "Avoid printing braces for one-statement blocks in js-printer." (Closed)

Created:
5 years, 10 months ago by floitsch

Modified:
5 years, 10 months ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org, Vyacheslav Egorov (Google)

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "Avoid printing braces for one-statement blocks in js-printer." This reverts commit r43956. Committed: https://code.google.com/p/dart/source/detail?r=43964

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -87 lines)			Patch
M	pkg/compiler/lib/src/js/nodes.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js/printer.dart	View	10 chunks	+14 lines, -30 lines	0 comments	Download
M	tests/compiler/dart2js/async_await_js_transform_test.dart	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/js_parser_statements_test.dart	View	4 chunks	+4 lines, -52 lines	0 comments	Download

Total messages: 5 (1 generated)

floitsch

It looks like IE requires more "{}" than the spec mandates. Reverting...

5 years, 10 months ago (2015-02-23 17:18:58 UTC) #2

floitsch

Committed patchset #1 (id:1) manually as 43964 (presubmit successful).

5 years, 10 months ago (2015-02-23 17:19:26 UTC) #4

Message was sent while issue was closed.

LGTM

thanks