Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 954473003: Revert of ui: Add another presubmit check to catch two more scoped_ptr usages. (Closed)

Created:
5 years, 10 months ago by scottmg
Modified:
5 years, 10 months ago
CC:
chromium-reviews, danakj, tapted
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ui: Add another presubmit check to catch two more scoped_ptr usages. (patchset #6 id:100001 of https://codereview.chromium.org/919253002/) Reason for revert: Presubmit in ui/ failing with ... File "<string>", line 38, in CheckScopedPtr NameError: global name 're' is not defined Original issue's description: > ui: Add another presubmit check to catch two more scoped_ptr usages. > > This should catch the following usages: > > 1- return scoped_ptr<T>(foo) > 2- bar = scoped_ptr<T>(foo) > > And recommend the solo usage of make_scoped_ptr(). > > The entries were found with the following command line: > > $ git grep -E '(=|\breturn)\s*scoped_ptr<.*?>([^)]+)' > > BUG=None > TEST=g cl presubmit -uv > R=sky@chromium.org,maruel@chromium.org > > Committed: https://crrev.com/63f25bef305bd8143766e2e1a98bf01548c78376 > Cr-Commit-Position: refs/heads/master@{#317669} TBR=maruel@chromium.org,sky@chromium.org,maruel@google.com,sadrul@chromium.org,tfarina@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=None Committed: https://crrev.com/511f02da1423bf3a8e365a88ddf77b676f6998d0 Cr-Commit-Position: refs/heads/master@{#317686}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -16 lines) Patch
M ui/PRESUBMIT.py View 2 chunks +4 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scottmg
Created Revert of ui: Add another presubmit check to catch two more scoped_ptr usages.
5 years, 10 months ago (2015-02-24 00:19:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954473003/1
5 years, 10 months ago (2015-02-24 00:19:52 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-24 00:21:27 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/511f02da1423bf3a8e365a88ddf77b676f6998d0 Cr-Commit-Position: refs/heads/master@{#317686}
5 years, 10 months ago (2015-02-24 00:22:01 UTC) #4
tfarina
5 years, 10 months ago (2015-02-24 00:23:51 UTC) #5
Message was sent while issue was closed.
Gosh!!

On Mon, Feb 23, 2015 at 9:22 PM, <commit-bot@chromium.org> wrote:

> Patchset 1 (id:??) landed as
> https://crrev.com/511f02da1423bf3a8e365a88ddf77b676f6998d0
> Cr-Commit-Position: refs/heads/master@{#317686}
>
> https://codereview.chromium.org/954473003/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698