Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issue 954453003: Reset conicWeights in SkPath::consumeDegenerateSegments when rewinding to last Move op (Closed)

Created:
5 years, 10 months ago by robertphillips
Modified:
5 years, 10 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reset conicWeights in SkPath::consumeDegenerateSegments when rewinding to last Move op Without this patch the iterator can end up running off the end of the conic weights if there is a mixture of degenerate and non-degenerate ops Note: we might want to suppress the generation of degenerate conics and lines in SkPath::addRRect BUG=459897 Committed: https://skia.googlesource.com/skia/+/b8de1f46594c3cd9c537f0b128c6d6eb30a9f463

Patch Set 1 #

Patch Set 2 : Added unit test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M src/core/SkPath.cpp View 5 chunks +5 lines, -0 lines 0 comments Download
M tests/PathTest.cpp View 1 1 chunk +14 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (3 generated)
robertphillips
5 years, 10 months ago (2015-02-23 17:46:09 UTC) #2
robertphillips
5 years, 10 months ago (2015-02-23 18:52:51 UTC) #4
robertphillips
https://codereview.chromium.org/954453003/diff/20001/tests/PathTest.cpp File tests/PathTest.cpp (right): https://codereview.chromium.org/954453003/diff/20001/tests/PathTest.cpp#newcode2490 tests/PathTest.cpp:2490: REPORTER_ASSERT(reporter, SkPath::kConic_Verb == iter.next(pts)); This next line will trigger ...
5 years, 10 months ago (2015-02-23 18:53:48 UTC) #5
caryclark
lgtm
5 years, 10 months ago (2015-02-23 18:55:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954453003/20001
5 years, 10 months ago (2015-02-23 18:58:41 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-23 19:17:04 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b8de1f46594c3cd9c537f0b128c6d6eb30a9f463

Powered by Google App Engine
This is Rietveld 408576698