Issue 954393002: Revert "[WebSocket] Add NOINLINE function calls to see the stack trace."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954393002: Revert "[WebSocket] Add NOINLINE function calls to see the stack trace." (Closed)

Created:
5 years, 10 months ago by Adam Rice

Modified:
5 years, 10 months ago

Reviewers:
yhirano

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert "[WebSocket] Add NOINLINE function calls to see the stack trace." Bug 399535 is fixed so we no longer need the additional functions added to debug it. This reverts commit 27b2b57ce6d4e03728b3addf305f00d114b32e19. BUG=399535 Committed: https://crrev.com/24c195f8b43b0eb75d1744e4d1eb95d7bd2fb2a6 Cr-Commit-Position: refs/heads/master@{#318221}

Patch Set 1 #

Patch Set 2 : Fix parts lost in the merge. #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -51 lines)			Patch
	M	net/websockets/websocket_basic_handshake_stream.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	net/websockets/websocket_basic_handshake_stream.cc	View	1	4 chunks	+3 lines, -50 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954393002/20001

5 years, 10 months ago (2015-02-26 11:30:18 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-26 12:20:02 UTC) #7

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/24c195f8b43b0eb75d1744e4d1eb95d7bd2fb2a6
Cr-Commit-Position: refs/heads/master@{#318221}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages