Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 954383002: Enable NaCl on the Linux GN x64 release build (only). (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, Nick Bray (chromium), jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable NaCl on the Linux GN x64 release build (only). I don't think any other config will work at the moment. Note that this is also totally untested, but should at least compile :). R=brettw@chromium.org BUG=432959 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/2ea95fb51c079912c99ff90a4579e02d802a73e9 Cr-Commit-Position: refs/heads/master@{#318329}

Patch Set 1 #

Patch Set 2 : make sure the mojo/nacl targets have the "right" include dirs set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -7 lines) Patch
M build/config/features.gni View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/nacl/BUILD.gn View 1 3 chunks +25 lines, -2 lines 0 comments Download
M ppapi/native_client/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
Dirk Pranke
5 years, 9 months ago (2015-02-26 04:23:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954383002/1
5 years, 9 months ago (2015-02-26 04:26:23 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-02-26 04:26:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954383002/1
5 years, 9 months ago (2015-02-26 04:28:32 UTC) #7
brettw
lgtm
5 years, 9 months ago (2015-02-26 17:56:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954383002/20001
5 years, 9 months ago (2015-02-26 20:57:13 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-26 22:18:57 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-02-26 22:20:02 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2ea95fb51c079912c99ff90a4579e02d802a73e9
Cr-Commit-Position: refs/heads/master@{#318329}

Powered by Google App Engine
This is Rietveld 408576698