[Webapp Refactor] Group authentications fields into remoting.CredentialsProvider.

remoting/webapp/crd/js/client_plugin.js

Index: remoting/webapp/crd/js/client_plugin.js
diff --git a/remoting/webapp/crd/js/client_plugin.js b/remoting/webapp/crd/js/client_plugin.js
index a7fdd34d1fba5cc92262f7ed6a99aae90a94a20d..4e32e55fb41d621640baf8e601c6cedf04a68d6b 100644
--- a/remoting/webapp/crd/js/client_plugin.js
+++ b/remoting/webapp/crd/js/client_plugin.js
@@ -34,25 +34,12 @@ remoting.ClientPlugin.prototype.element = function() {};
 remoting.ClientPlugin.prototype.initialize = function(onDone) {};
 
 /**
- * @param {string} hostJid The jid of the host to connect to.
- * @param {string} hostPublicKey The base64 encoded version of the host's
- *     public key.
+ * @param {remoting.Host} host The host to connect to.
  * @param {string} localJid Local jid.
- * @param {string} sharedSecret The access code for IT2Me or the PIN
- *     for Me2Me.
- * @param {string} authenticationMethods Comma-separated list of
- *     authentication methods the client should attempt to use.
- * @param {string} authenticationTag A host-specific tag to mix into
- *     authentication hashes.
- * @param {string} clientPairingId For paired Me2Me connections, the
- *     pairing id for this client, as issued by the host.
- * @param {string} clientPairedSecret For paired Me2Me connections, the
- *     paired secret for this client, as issued by the host.
- */
-remoting.ClientPlugin.prototype.connect = function(
-    hostJid, hostPublicKey, localJid, sharedSecret,
-    authenticationMethods, authenticationTag,
-    clientPairingId, clientPairedSecret) {};
+ * @param {remoting.CredentialsProvider} credentials The credentials
+ */
+remoting.ClientPlugin.prototype.connect =
+    function(host, localJid, credentials) {};
 
 /**
  * @param {number} key The keycode to inject.
@@ -98,11 +85,6 @@ remoting.ClientPlugin.prototype.sendClipboardItem =
     function(mimeType, item) {};
 
 /**
- * Tell the plugin to request a PIN asynchronously.
- */
-remoting.ClientPlugin.prototype.useAsyncPinDialog = function() {};

[Jamie, 2015/02/26 23:20:14]

Please mention in the CL description that you're removing this member.

[kelvinp, 2015/02/27 01:03:20]

Done.

-
-/**
  * Request that this client be paired with the current host.
  *
  * @param {string} clientName The human-readable name of the client.
@@ -113,27 +95,11 @@ remoting.ClientPlugin.prototype.requestPairing =
     function(clientName, onDone) {};
 
 /**
- * Called when a PIN is obtained from the user.
- *
- * @param {string} pin The PIN.
- */
-remoting.ClientPlugin.prototype.onPinFetched = function(pin) {};
-
-/**
  * Allows automatic mouse-lock.
  */
 remoting.ClientPlugin.prototype.allowMouseLock = function() {};
 
 /**
- * Sets the third party authentication token and shared secret.
- *
- * @param {string} token The token received from the token URL.
- * @param {string} sharedSecret Shared secret received from the token URL.
- */
-remoting.ClientPlugin.prototype.onThirdPartyTokenFetched =
-    function(token, sharedSecret) {};
-
-/**
  * @param {boolean} pause True to pause the audio stream; false to resume it.
  */
 remoting.ClientPlugin.prototype.pauseAudio = function(pause) {};
@@ -223,23 +189,6 @@ remoting.ClientPlugin.prototype.setMouseCursorHandler =
     function(handler) {};
 
 /**
- * @param {function(string, string, string):void} handler Callback for
- *     fetching third-party tokens. The first parameter is the token URL; the
- *     second is the public key of the host; the third is the OAuth2 scope
- *     being requested.
- */
-remoting.ClientPlugin.prototype.setFetchThirdPartyTokenHandler =
-    function(handler) {};
-
-/**
- * @param {function(boolean):void} handler Callback for fetching a PIN from
- *     the user. The parameter is true if PIN pairing is supported by the
- *     host, or false otherwise.
- */
-remoting.ClientPlugin.prototype.setFetchPinHandler =
-    function(handler) {};
-
-/**
  * @param {function({rects:Array<Array<number>>}):void|null} handler Callback
  *     to receive dirty region information for each video frame, for debugging.
  */