Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(840)

Issue 954363002: Fix sort order of unlaunched apps on app list start page. (Closed)

Created:
5 years, 9 months ago by calamity
Modified:
5 years, 9 months ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@add_start_page_context_and_logs
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix sort order of unlaunched apps on app list start page. This CL fixes an issue with the app list start page sort order for unlaunched apps. Folder items were being weighted too highly, causing them to appear first. The items that are not in a folder will now appear first in the recommendations, in app list order. BUG=455338 Committed: https://crrev.com/0f1ee572dcbbd4a283bccafe07ac071092003357 Cr-Commit-Position: refs/heads/master@{#318642}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add test #

Patch Set 3 : rebase #

Patch Set 4 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -3 lines) Patch
M chrome/browser/ui/app_list/search/app_search_provider.cc View 1 2 3 1 chunk +10 lines, -3 lines 0 comments Download
M chrome/browser/ui/app_list/search/app_search_provider_unittest.cc View 1 3 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
calamity
5 years, 9 months ago (2015-02-27 05:40:33 UTC) #4
Matt Giuca
"The items that are not in a folder will now appear app list order." fix ...
5 years, 9 months ago (2015-02-27 06:00:48 UTC) #5
Matt Giuca
lgtm https://codereview.chromium.org/954363002/diff/1/chrome/browser/ui/app_list/search/app_search_provider.cc File chrome/browser/ui/app_list/search/app_search_provider.cc (right): https://codereview.chromium.org/954363002/diff/1/chrome/browser/ui/app_list/search/app_search_provider.cc#newcode116 chrome/browser/ui/app_list/search/app_search_provider.cc:116: size_t app_list_index = // If it's in a ...
5 years, 9 months ago (2015-02-27 06:03:53 UTC) #6
calamity
https://codereview.chromium.org/954363002/diff/1/chrome/browser/ui/app_list/search/app_search_provider.cc File chrome/browser/ui/app_list/search/app_search_provider.cc (right): https://codereview.chromium.org/954363002/diff/1/chrome/browser/ui/app_list/search/app_search_provider.cc#newcode116 chrome/browser/ui/app_list/search/app_search_provider.cc:116: size_t app_list_index = On 2015/02/27 06:03:53, Matt Giuca wrote: ...
5 years, 9 months ago (2015-03-02 00:50:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954363002/100001
5 years, 9 months ago (2015-03-02 00:51:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/1034)
5 years, 9 months ago (2015-03-02 00:56:38 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954363002/100001
5 years, 9 months ago (2015-03-02 02:50:32 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 9 months ago (2015-03-02 03:09:06 UTC) #15
commit-bot: I haz the power
5 years, 9 months ago (2015-03-02 03:10:18 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0f1ee572dcbbd4a283bccafe07ac071092003357
Cr-Commit-Position: refs/heads/master@{#318642}

Powered by Google App Engine
This is Rietveld 408576698