ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.html - Issue 954293003: Support badges and connecting animation in cr-network-icon element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.html

Issue 954293003: Support badges and connecting animation in cr-network-icon element (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: More Feedback Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.css ('k') | ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.html

diff --git a/ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.html b/ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.html

index a8a53fb2ffa2440bd47394afbfb943335fcae32c..4762f6cde1664dcbe2d8c8bb884db6ba60870e5c 100644

--- a/ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.html

+++ b/ui/webui/resources/cr_elements/cr_network_icon/cr_network_icon.html

@@ -3,9 +3,15 @@

<polymer-element name="cr-network-icon">

- <img id="icon">

+ <img id="icon" src="{{iconType | toImageSrc}}">

+ <img id="technology" src="{{technology | toBadgeImageSrc}}"

+ hidden?="{{!technology}}">

+ <img id="roaming"

+ src="chrome://resources/cr_elements/cr_network_icon/badge_roaming.png"

+ hidden?="{{!roaming}}">

<img id="secure"

- src="chrome://resources/cr_elements/cr_network_icon/secure.png">

+ src="chrome://resources/cr_elements/cr_network_icon/badge_secure.png"

+ hidden?="{{!secure}}">

</template>

</polymer-element>