Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2871)

Unified Diff: mojo/services/view_manager/public/interfaces/view_manager.mojom

Issue 954273002: Routes WindowManager functionality through the view manager (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/view_manager/public/interfaces/view_manager.mojom
diff --git a/mojo/services/view_manager/public/interfaces/view_manager.mojom b/mojo/services/view_manager/public/interfaces/view_manager.mojom
index 3bd8f1ecdd8d4d28d8701946524d8a87314a9310..0a2564eeceb1470a6033806a928f8839c14b84d8 100644
--- a/mojo/services/view_manager/public/interfaces/view_manager.mojom
+++ b/mojo/services/view_manager/public/interfaces/view_manager.mojom
@@ -142,6 +142,14 @@ interface ViewManagerService {
ServiceProvider&? services,
ServiceProvider? exposed_services) => (bool success);
Embed(uint32 view_id, ViewManagerClient client) => (bool success);
+
+ // Requests the WindowManager to perform an action on the specified view.
+ // It's up to the WindowManager to decide what |action| is.
+ //
+ // TODO(sky): nuke this. This is here to guarantee the state of the
+ // WindowManager matches that of the ViewManager at the time the client
+ // invokes the function. When we can enforce ordering this won't be necessary.
+ PerformAction(uint32 view_id, string action) => (bool success);
};
// Changes to views are not sent to the connection that originated the
@@ -214,4 +222,9 @@ interface ViewManagerClient {
// Invoked when an event is targeted at the specified view.
OnViewInputEvent(uint32 view, mojo.Event event) => ();
+
+ // Invoked solely on the WindowManager. See comments in PerformAction() above
+ // for details.
+ // TODO(sky): nuke this.
+ OnPerformAction(uint32 view_id, string action) => (bool success);
};
« no previous file with comments | « mojo/services/view_manager/public/cpp/view_manager_delegate.cc ('k') | services/view_manager/connection_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698