Issue 954243002: Revert of Default SK_ANGLE to true on Windows, run angle whenever possible on bots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 954243002: Revert of Default SK_ANGLE to true on Windows, run angle whenever possible on bots. (Closed)

Created:
5 years, 10 months ago by mtklein

Modified:
5 years, 10 months ago

Reviewers:
bsalomon, mtklein_C

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Default SK_ANGLE to true on Windows, run angle whenever possible on bots. (patchset #3 id:40001 of https://codereview.chromium.org/946933006/) Reason for revert: Needs bot upgrades. Original issue's description: > Default SK_ANGLE to true on Windows, run angle whenever possible on bots. > > nanobench doesn't need an update. It uses the default for --config, > which includes angle. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/88ec329b580a081d9d56cbcaad0ee46cb941c849 TBR=bsalomon@google.com,mtklein@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/ee2a3eaf996826ec603748c7f79d4d6b5cf0ecc3

Created: 5 years, 10 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -7 lines)			Patch
M	gyp/common_variables.gypi	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	tools/dm_flags.json	View	5 chunks	+19 lines, -4 lines	0 comments	Download
M	tools/dm_flags.py	View	2 chunks	+4 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Default SK_ANGLE to true on Windows, run angle whenever possible on bots.

5 years, 10 months ago (2015-02-25 16:15:09 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954243002/1

5 years, 10 months ago (2015-02-25 16:16:13 UTC) #2

commit-bot: I haz the power

5 years, 10 months ago (2015-02-25 16:16:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ee2a3eaf996826ec603748c7f79d4d6b5cf0ecc3