Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 954213002: CredentialsItemView should use UTF8ToUTF16 for the hostname. (Closed)

Created:
5 years, 10 months ago by vasilii
Modified:
5 years, 10 months ago
Reviewers:
Mike West
CC:
chromium-reviews, tfarina, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CredentialsItemView should use UTF8ToUTF16 for the hostname. BUG=400674 Committed: https://crrev.com/3065103aefb405b07a054d95ddf591c6c6773094 Cr-Commit-Position: refs/heads/master@{#318050}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/passwords/credentials_item_view.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vasilii
Hi Mike, this bug fix was influenced by your CL!
5 years, 10 months ago (2015-02-25 13:56:45 UTC) #2
Mike West
I am an influencer! LGTM.
5 years, 10 months ago (2015-02-25 14:01:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954213002/1
5 years, 10 months ago (2015-02-25 14:59:28 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 15:36:34 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 15:37:20 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3065103aefb405b07a054d95ddf591c6c6773094
Cr-Commit-Position: refs/heads/master@{#318050}

Powered by Google App Engine
This is Rietveld 408576698