Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1100)

Issue 954183005: Let TestMockTimeTaskRunner ignore task nestability. (Closed)

Created:
5 years, 10 months ago by engedy
Modified:
5 years, 9 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Let TestMockTimeTaskRunner ignore task nestability. Let TestMockTimeTaskRunner ignore task nestability as opposed to outright disallowing nested tasks. This is in line with the behavior of TestSimpleTaskRunner. BUG=None Committed: https://crrev.com/03c1e91c34418d98e52d68a7ef7ea3b6c626d575 Cr-Commit-Position: refs/heads/master@{#318512}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/test/test_mock_time_task_runner.h View 1 chunk +1 line, -2 lines 0 comments Download
M base/test/test_mock_time_task_runner.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
engedy
@Paweł, could you please take a quick look? This is needed for supporting DeleteSoon().
5 years, 10 months ago (2015-02-25 16:13:45 UTC) #2
Paweł Hajdan Jr.
LGTM
5 years, 9 months ago (2015-02-27 19:42:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954183005/1
5 years, 9 months ago (2015-02-27 19:56:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-02-27 20:54:21 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-02-27 20:54:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03c1e91c34418d98e52d68a7ef7ea3b6c626d575
Cr-Commit-Position: refs/heads/master@{#318512}

Powered by Google App Engine
This is Rietveld 408576698