Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(906)

Side by Side Diff: PRESUBMIT.py

Issue 954183004: Port public version macros. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@4.1
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2012 the V8 project authors. All rights reserved. 1 # Copyright 2012 the V8 project authors. All rights reserved.
2 # Redistribution and use in source and binary forms, with or without 2 # Redistribution and use in source and binary forms, with or without
3 # modification, are permitted provided that the following conditions are 3 # modification, are permitted provided that the following conditions are
4 # met: 4 # met:
5 # 5 #
6 # * Redistributions of source code must retain the above copyright 6 # * Redistributions of source code must retain the above copyright
7 # notice, this list of conditions and the following disclaimer. 7 # notice, this list of conditions and the following disclaimer.
8 # * Redistributions in binary form must reproduce the above 8 # * Redistributions in binary form must reproduce the above
9 # copyright notice, this list of conditions and the following 9 # copyright notice, this list of conditions and the following
10 # disclaimer in the documentation and/or other materials provided 10 # disclaimer in the documentation and/or other materials provided
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 input_api, output_api)) 191 input_api, output_api))
192 results.extend(_V8PresubmitChecks(input_api, output_api)) 192 results.extend(_V8PresubmitChecks(input_api, output_api))
193 results.extend(_CheckUnwantedDependencies(input_api, output_api)) 193 results.extend(_CheckUnwantedDependencies(input_api, output_api))
194 results.extend( 194 results.extend(
195 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api)) 195 _CheckNoProductionCodeUsingTestOnlyFunctions(input_api, output_api))
196 return results 196 return results
197 197
198 198
199 def _SkipTreeCheck(input_api, output_api): 199 def _SkipTreeCheck(input_api, output_api):
200 """Check the env var whether we want to skip tree check. 200 """Check the env var whether we want to skip tree check.
201 Only skip if src/version.cc has been updated.""" 201 Only skip if include/v8-version.h has been updated."""
202 src_version = 'src/version.cc' 202 src_version = 'include/v8-version.h'
203 FilterFile = lambda file: file.LocalPath() == src_version 203 FilterFile = lambda file: file.LocalPath() == src_version
204 if not input_api.AffectedSourceFiles( 204 if not input_api.AffectedSourceFiles(
205 lambda file: file.LocalPath() == src_version): 205 lambda file: file.LocalPath() == src_version):
206 return False 206 return False
207 return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip' 207 return input_api.environ.get('PRESUBMIT_TREE_CHECK') == 'skip'
208 208
209 209
210 def _CheckChangeLogFlag(input_api, output_api): 210 def _CheckChangeLogFlag(input_api, output_api):
211 """Checks usage of LOG= flag in the commit message.""" 211 """Checks usage of LOG= flag in the commit message."""
212 results = [] 212 results = []
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
247 'v8_linux64_rel': set(['defaulttests']), 247 'v8_linux64_rel': set(['defaulttests']),
248 'v8_linux_arm_dbg': set(['defaulttests']), 248 'v8_linux_arm_dbg': set(['defaulttests']),
249 'v8_linux_arm64_rel': set(['defaulttests']), 249 'v8_linux_arm64_rel': set(['defaulttests']),
250 'v8_linux_layout_dbg': set(['defaulttests']), 250 'v8_linux_layout_dbg': set(['defaulttests']),
251 'v8_linux_chromium_gn_rel': set(['defaulttests']), 251 'v8_linux_chromium_gn_rel': set(['defaulttests']),
252 'v8_mac_rel': set(['defaulttests']), 252 'v8_mac_rel': set(['defaulttests']),
253 'v8_win_rel': set(['defaulttests']), 253 'v8_win_rel': set(['defaulttests']),
254 'v8_win64_compile_rel': set(['defaulttests']), 254 'v8_win64_compile_rel': set(['defaulttests']),
255 }, 255 },
256 } 256 }
OLDNEW
« no previous file with comments | « no previous file | include/v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698