Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 954173002: [turbofan] Fix simplified lowering of Int32Div. (Closed)

Created:
5 years, 10 months ago by Benedikt Meurer
Modified:
5 years, 10 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix simplified lowering of Int32Div. Optimize for the common case and get rid of the unreadable Diamond helper code there. R=dcarney@chromium.org Committed: https://crrev.com/6a42682975ef084545ca8b16994d0ed1970c6af6 Cr-Commit-Position: refs/heads/master@{#26843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -12 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +54 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 10 months ago (2015-02-25 09:07:19 UTC) #1
Benedikt Meurer
PTAL
5 years, 10 months ago (2015-02-25 09:07:41 UTC) #2
dcarney
lgtm
5 years, 10 months ago (2015-02-25 09:43:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954173002/1
5 years, 10 months ago (2015-02-25 09:45:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 09:46:04 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 09:46:21 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6a42682975ef084545ca8b16994d0ed1970c6af6
Cr-Commit-Position: refs/heads/master@{#26843}

Powered by Google App Engine
This is Rietveld 408576698