Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 954153002: Trigger a landmine on first-time landmine deployment. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Trigger a landmine on first-time landmine deployment. Without this change, it is non-trivial to know during runhooks, if a landmine was just triggered in a checkout that doesn't have the initial landmines script CL yet, i.e. that didn't create a .landmines file yet. BUG=chromium:403263 LOG=n Committed: https://crrev.com/0fff64da8b204dec3e5302b9ac3408664e8b19ee Cr-Commit-Position: refs/heads/master@{#26842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -19 lines) Patch
M build/landmines.py View 2 chunks +27 lines, -19 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-25 08:54:36 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-02-25 08:56:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954153002/1
5 years, 10 months ago (2015-02-25 09:09:33 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-25 09:20:00 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 09:20:16 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fff64da8b204dec3e5302b9ac3408664e8b19ee
Cr-Commit-Position: refs/heads/master@{#26842}

Powered by Google App Engine
This is Rietveld 408576698