Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 954113004: [Files.app] Add a shortcut key (Ctrl-Shift-E) to eject a removable device (Closed)

Created:
5 years, 10 months ago by yoshiki
Modified:
5 years, 10 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Add a shortcut key (Ctrl-Shift-E) to eject a removable device BUG=459693 TEST=manually tested Committed: https://crrev.com/5c7a0dc6f337f8a2c086df5ef0d9b6d4984bffe5 Cr-Commit-Position: refs/heads/master@{#318179}

Patch Set 1 #

Patch Set 2 : Added a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M ui/file_manager/file_manager/main.html View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 10 months ago (2015-02-25 14:59:19 UTC) #2
fukino
lgtm.
5 years, 10 months ago (2015-02-25 15:44:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954113004/20001
5 years, 10 months ago (2015-02-26 00:32:45 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ng/builds/14846) ios_rel_device_ninja_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 10 months ago (2015-02-26 00:35:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/954113004/20001
5 years, 10 months ago (2015-02-26 02:06:11 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-26 03:15:00 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-26 03:17:24 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c7a0dc6f337f8a2c086df5ef0d9b6d4984bffe5
Cr-Commit-Position: refs/heads/master@{#318179}

Powered by Google App Engine
This is Rietveld 408576698