Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1145)

Unified Diff: chrome/android/java/res/layout/autofill_credit_card_editor.xml

Issue 954063003: Fix the last lint warnings in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/layout/autofill_credit_card_editor.xml
diff --git a/chrome/android/java/res/layout/autofill_credit_card_editor.xml b/chrome/android/java/res/layout/autofill_credit_card_editor.xml
index 4ef788d95a49ff39d40fd93e6c211c670767d510..d949a1ef946109b56548a2828b2deefcb0156b85 100644
--- a/chrome/android/java/res/layout/autofill_credit_card_editor.xml
+++ b/chrome/android/java/res/layout/autofill_credit_card_editor.xml
@@ -15,6 +15,9 @@
android:layout_height="wrap_content"
android:orientation="vertical" >
+ <!-- EditText views in FloatLabelLayout require both hint and contentDescription to be set
+ to work correctly for accessibility because FloatLabelLayout sometimes clear hint. -->
+ <!--suppress ContentDescription -->
<LinearLayout
style="@style/PreferenceScreenLayout"
android:layout_width="match_parent"
@@ -67,6 +70,7 @@
android:layout_height="wrap_content"
android:orientation="horizontal"
android:paddingTop="8dp"
+ android:baselineAligned="false"
android:layout_marginStart="@dimen/pref_autofill_field_horizontal_padding"
android:layout_marginEnd="@dimen/pref_autofill_field_horizontal_padding" >

Powered by Google App Engine
This is Rietveld 408576698