Kiosk mode: SetFirstLoginPrefs() should be called for kiosk sessions.

chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/users/chrome_user_manager_impl.h"
 
 #include <cstddef>
 #include <set>
 
 #include "ash/multi_profile_uma.h"
@@ skipping 703 matching lines @@
             device_local_account_type);
 
   active_user_ = user_manager::User::CreateKioskAppUser(app_id);
   active_user_->SetStubImage(
       user_manager::UserImage(
           *ResourceBundle::GetSharedInstance().GetImageSkiaNamed(
               IDR_PROFILE_PICTURE_LOADING)),
       user_manager::User::USER_IMAGE_INVALID,
       false);
 
+  SetIsCurrentUserNew(true);

[xiyuan, 2015/02/25 20:18:43]

KioskAppLoggedIn is called on every kiosk app launch. App is like regular user
and it's cryptohome/profile is persisted. So it is not always a "new" user.
Would lying here have side effects?

We had problems with input before. At that time, the bug is fixed
 by explicitly calling InitChromeOSPreferences() on kiosk launch code path in
AppLaunchController::OnProfileLoaded [1]. Could we do something similar and call
SetFirstLoginPrefs with proper args there?

[1]:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chr...

[Alexander Alekseev, 2015/02/25 20:48:47]

We only need to call SetFirstLoginPrefs for the first Kiosk session.
Is there way to catch first Kiosk session?

[xiyuan, 2015/02/25 21:20:50]

Think we can use Profile::IsNewProfile to check whether this is the first kiosk
run.

   WallpaperManager::Get()->SetUserWallpaperNow(app_id);
 
   // TODO(bartfab): Add KioskAppUsers to the users_ list and keep metadata like
   // the kiosk_app_id in these objects, removing the need to re-parse the
   // device-local account list here to extract the kiosk_app_id.
   const std::vector<policy::DeviceLocalAccount> device_local_accounts =
       policy::GetDeviceLocalAccounts(cros_settings_);
   const policy::DeviceLocalAccount* account = NULL;
   for (std::vector<policy::DeviceLocalAccount>::const_iterator it =
            device_local_accounts.begin();
@@ skipping 347 matching lines @@
 
   if (profile->GetPrefs()->GetBoolean(prefs::kResolveTimezoneByGeolocation) &&
       !system::HasSystemTimezonePolicy()) {
     g_browser_process->platform_part()->GetTimezoneResolver()->Start();
   } else {
     g_browser_process->platform_part()->GetTimezoneResolver()->Stop();
   }
 }
 
 }  // namespace chromeos