Issue 954023002: Implement quantum ink splashes

Issue 954023002: Implement quantum ink splashes (Closed)

Created:
5 years, 10 months ago by abarth-chromium

Modified:
5 years, 10 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, esprehn, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Implement quantum ink splashes These aren't 100% correct, but they look somewhat reasonable. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/515f16eacd323db38555d1a8f928d6bdd969ca82

Patch Set 2 : nits #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -2 lines)			Patch
M	sky/examples/stocks/stock.sky	View		2 chunks	+2 lines, -1 line	0 comments	Download
A	sky/framework/material-element.sky	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
M	sky/framework/sky-drawer.sky	View		1 chunk	+1 line, -1 line	0 comments	Download
A	sky/framework/sky-ink-splash.sky	View		1 chunk	+84 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/954023002/diff/1/sky/framework/material-element.sky File sky/framework/material-element.sky (right): https://codereview.chromium.org/954023002/diff/1/sky/framework/material-element.sky#newcode19 sky/framework/material-element.sky:19: style['transform'] = 'translateX(0)'; Add FIXME.

5 years, 10 months ago (2015-02-24 23:38:58 UTC) #2

eseidel

https://codereview.chromium.org/954023002/diff/1/sky/framework/sky-menu-item.sky File sky/framework/sky-menu-item.sky (right): https://codereview.chromium.org/954023002/diff/1/sky/framework/sky-menu-item.sky#newcode42 sky/framework/sky-menu-item.sky:42: super.shadowRootReady(); This will still work, correct?

5 years, 10 months ago (2015-02-24 23:39:12 UTC) #3

abarth-chromium

5 years, 10 months ago (2015-02-24 23:41:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
515f16eacd323db38555d1a8f928d6bdd969ca82 (presubmit successful).

Expand Messages | Collapse Messages