Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: pkg/analysis_server/lib/src/channel/web_socket_channel.dart

Issue 954013002: Replace try/finally with PerformanceTag.makeCurrentWhile(). (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/channel/web_socket_channel.dart
diff --git a/pkg/analysis_server/lib/src/channel/web_socket_channel.dart b/pkg/analysis_server/lib/src/channel/web_socket_channel.dart
index e70bd005aafde78a842ef649e0088bef2912a784..47af214ea041012feb69d2fe308582ed362ec1de 100644
--- a/pkg/analysis_server/lib/src/channel/web_socket_channel.dart
+++ b/pkg/analysis_server/lib/src/channel/web_socket_channel.dart
@@ -12,7 +12,6 @@ import 'package:analysis_server/src/analysis_server.dart';
import 'package:analysis_server/src/channel/channel.dart';
import 'package:analysis_server/src/protocol.dart';
import 'package:analyzer/instrumentation/instrumentation.dart';
-import 'package:analyzer/src/generated/utilities_general.dart';
/**
@@ -107,18 +106,14 @@ class WebSocketServerChannel implements ServerCommunicationChannel {
instrumentationService.logRequest(data);
// Parse the string as a JSON descriptor and process the resulting
// structure as a request.
- PerformanceTag prevTag =
- ServerPerformanceStatistics.serverChannel.makeCurrent();
- try {
+ ServerPerformanceStatistics.serverChannel.makeCurrentWhile(() {
Request request = new Request.fromString(data);
if (request == null) {
sendResponse(new Response.invalidRequestFormat());
return;
}
onRequest(request);
- } finally {
- prevTag.makeCurrent();
- }
+ });
} else if (data is List<int>) {
// TODO(brianwilkerson) Implement a more efficient protocol.
sendResponse(new Response.invalidRequestFormat());
@@ -129,27 +124,19 @@ class WebSocketServerChannel implements ServerCommunicationChannel {
@override
void sendNotification(Notification notification) {
- PerformanceTag prevTag =
- ServerPerformanceStatistics.serverChannel.makeCurrent();
- try {
+ ServerPerformanceStatistics.serverChannel.makeCurrentWhile(() {
String jsonEncoding = JSON.encode(notification.toJson());
socket.add(jsonEncoding);
instrumentationService.logNotification(jsonEncoding);
- } finally {
- prevTag.makeCurrent();
- }
+ });
}
@override
void sendResponse(Response response) {
- PerformanceTag prevTag =
- ServerPerformanceStatistics.serverChannel.makeCurrent();
- try {
+ ServerPerformanceStatistics.serverChannel.makeCurrentWhile(() {
String jsonEncoding = JSON.encode(response.toJson());
socket.add(jsonEncoding);
instrumentationService.logResponse(jsonEncoding);
- } finally {
- prevTag.makeCurrent();
- }
+ });
}
}

Powered by Google App Engine
This is Rietveld 408576698