Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 953993002: Re-enable the new SQLitePersistentCookieStore load strategy. (Closed)

Created:
5 years, 10 months ago by erikchen
Modified:
5 years, 10 months ago
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable the new SQLitePersistentCookieStore load strategy. When I first turned on the new load strategy, it caused deadlocks during shutdown. I found and fixed the bug in SequencedWorkerPool. BUG=448910 Committed: https://crrev.com/043d6b497dda7a39138eca1fb9df89ee340e543b Cr-Commit-Position: refs/heads/master@{#318305}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
erikchen
erikwright: Please review. This CL fixes the deadlock: https://codereview.chromium.org/956583004/
5 years, 10 months ago (2015-02-26 18:40:44 UTC) #2
erikwright (departed)
LGTM.
5 years, 10 months ago (2015-02-26 18:45:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953993002/1
5 years, 10 months ago (2015-02-26 19:41:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-26 20:58:20 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/043d6b497dda7a39138eca1fb9df89ee340e543b Cr-Commit-Position: refs/heads/master@{#318305}
5 years, 10 months ago (2015-02-26 20:59:24 UTC) #7
erikchen
5 years, 9 months ago (2015-03-09 18:35:43 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/992723002/ by erikchen@chromium.org.

The reason for reverting is: This CL causes hangs during shutdown.

https://code.google.com/p/chromium/issues/detail?id=465271.

Powered by Google App Engine
This is Rietveld 408576698