Fix up ParseProgram and ParseModule to do something sane with module scopes

Fix up ParseProgram and ParseModule to do something sane with module scopes

The FunctionLiteral returned from the parser for modules now has a MODULE_SCOPE,
instead of associating the module scope with a Block inside it. This makes
it easy to get at the ModuleDescriptor from the caller of Parse(), so I've added
a basic test that pokes at the scope and the descriptor. Expect more tests
in this vein.

BUG=v8:1569
LOG=n

Committed: https://crrev.com/1a8dc98cbf9d661785444fa70ec7fbc2fd7e0d6c
Cr-Commit-Position: refs/heads/master@{#26836}

[adamk, 2015-02-24 22:05:49]

adamk@chromium.org changed reviewers:
+ arv@chromium.org, rossberg@chromium.org

[arv (Not doing code reviews), 2015-02-24 22:13:34]

https://codereview.chromium.org/953983002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/953983002/diff/1/src/parser.cc#newcode1256
src/parser.cc:1256: void* Parser::ParseModule(ZoneList<Statement*>* body, bool*
ok) {
Why return void* and not void?

https://codereview.chromium.org/953983002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/953983002/diff/1/test/cctest/test-parsing.cc#...
test/cctest/test-parsing.cc:5228: parser.set_allow_harmony_classes(true);
no need for classes here

[adamk, 2015-02-24 22:17:54]

https://codereview.chromium.org/953983002/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/953983002/diff/1/src/parser.cc#newcode1256
src/parser.cc:1256: void* Parser::ParseModule(ZoneList<Statement*>* body, bool*
ok) {
On 2015/02/24 22:13:34, arv wrote:
> Why return void* and not void?

For CHECK_OK.

We could do something else, like have two different sections of parse methods
that use CHECK_OK, not use CHECK_OK in void methods, or add CHECK_OK_VOID.

https://codereview.chromium.org/953983002/diff/1/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):

https://codereview.chromium.org/953983002/diff/1/test/cctest/test-parsing.cc#...
test/cctest/test-parsing.cc:5228: parser.set_allow_harmony_classes(true);
On 2015/02/24 22:13:34, arv wrote:
> no need for classes here

Removed.

[arv (Not doing code reviews), 2015-02-24 22:25:36]

LGTM

[adamk, 2015-02-24 22:37:19]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2015-02-24 22:38:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/953983002/40001

[commit-bot: I haz the power, 2015-02-24 22:39:33]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-24 22:39:45]

Patchset 3 (id:??) landed as
https://crrev.com/1a8dc98cbf9d661785444fa70ec7fbc2fd7e0d6c
Cr-Commit-Position: refs/heads/master@{#26836}

[rossberg, 2015-02-25 13:35:42]

https://codereview.chromium.org/953983002/diff/40001/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/953983002/diff/40001/src/parser.h#newcode706
src/parser.h:706: void* ParseModule(ZoneList<Statement*>* body, bool* ok);
Nit: Can we rename this to ParseModuleItemList, for more consistency with the
above? ParseModule sounds like it should either return a single AST node
corresponding to a Module, or be an entry point for parsing module scripts.

[adamk, 2015-02-25 18:55:21]

https://codereview.chromium.org/953983002/diff/40001/src/parser.h
File src/parser.h (right):

https://codereview.chromium.org/953983002/diff/40001/src/parser.h#newcode706
src/parser.h:706: void* ParseModule(ZoneList<Statement*>* body, bool* ok);
On 2015/02/25 13:35:42, rossberg wrote:
> Nit: Can we rename this to ParseModuleItemList, for more consistency with the
> above? ParseModule sounds like it should either return a single AST node
> corresponding to a Module, or be an entry point for parsing module scripts.

Sounds good, will rename in a one of these followups.