Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 953893002: Prepare v8 android perf runner for external startup data. (Closed)

Created:
5 years, 10 months ago by Michael Achenbach
Modified:
5 years, 10 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Prepare v8 android perf runner for external startup data. NOTRY=true Committed: https://crrev.com/c61fceca682d4068e43534c45440e7ebfffbc4ee Cr-Commit-Position: refs/heads/master@{#26825}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M tools/run_perf.py View 1 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Michael Achenbach
PTAL
5 years, 10 months ago (2015-02-24 13:21:10 UTC) #2
vogelheim
lgtm https://codereview.chromium.org/953893002/diff/1/tools/run_perf.py File tools/run_perf.py (right): https://codereview.chromium.org/953893002/diff/1/tools/run_perf.py#newcode536 tools/run_perf.py:536: def _PushFile(self, host_dir, file_name, target_rel=".", only_existing=True): Maybe it's ...
5 years, 10 months ago (2015-02-24 13:31:25 UTC) #3
Michael Achenbach
Done. Inverted the logic. It would be probably even cleaner to bail out instead of ...
5 years, 10 months ago (2015-02-24 14:05:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953893002/20001
5 years, 10 months ago (2015-02-24 14:07:10 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-24 14:07:20 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 14:07:39 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c61fceca682d4068e43534c45440e7ebfffbc4ee
Cr-Commit-Position: refs/heads/master@{#26825}

Powered by Google App Engine
This is Rietveld 408576698