Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: pkg/analyzer/test/source/package_map_resolver_test.dart

Issue 953863004: When converting files to package URI's, favor longer directory matches. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/source/package_map_resolver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/source/package_map_resolver_test.dart
diff --git a/pkg/analyzer/test/source/package_map_resolver_test.dart b/pkg/analyzer/test/source/package_map_resolver_test.dart
index cacb1868723f2d7b3a4b1e87638238e5a65ee9d6..1bce0e9404bb01dea7cd35fe1dac23d5be323339 100644
--- a/pkg/analyzer/test/source/package_map_resolver_test.dart
+++ b/pkg/analyzer/test/source/package_map_resolver_test.dart
@@ -200,6 +200,32 @@ class _PackageMapUriResolverTest {
expect(resolver.restoreAbsolute(source2), isNull);
}
+ void test_restoreLongestMatch() {
+ const file1 = '/foo1/bar1/lib.dart';
+ const file2 = '/foo2/bar2/lib.dart';
+ provider.newFile(file1, 'library lib');
+ provider.newFile(file2, 'library lib');
+ PackageMapUriResolver resolver =
+ new PackageMapUriResolver(provider, <String, List<Folder>>{
+ 'pkg1': [
+ provider.getResource('/foo1'),
+ provider.getResource('/foo2/bar2')],
+ 'pkg2': [
+ provider.getResource('/foo1/bar1'),
+ provider.getResource('/foo2')]
+ });
+ // Restoring file1 should yield a package URI for pkg2, since pkg2's match
+ // for the file path (/foo1/bar1) is longer than pkg1's match (/foo1).
+ Source source1 = _createFileSource(file1);
+ Uri uri1 = resolver.restoreAbsolute(source1);
+ expect(uri1.toString(), 'package:pkg2/lib.dart');
+ // Restoring file2 should yield a package URI for pkg1, since pkg1's match
+ // for the file path (/foo2/bar2) is longer than pkg2's match (/foo2).
+ Source source2 = _createFileSource(file2);
+ Uri uri2 = resolver.restoreAbsolute(source2);
+ expect(uri2.toString(), 'package:pkg1/lib.dart');
+ }
+
Source _createFileSource(String path) {
return new NonExistingSource(path, UriKind.FILE_URI);
}
« no previous file with comments | « pkg/analyzer/lib/source/package_map_resolver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698