Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Unified Diff: pkg/analyzer/lib/source/package_map_resolver.dart

Issue 953863004: When converting files to package URI's, favor longer directory matches. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/source/package_map_resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/source/package_map_resolver.dart
diff --git a/pkg/analyzer/lib/source/package_map_resolver.dart b/pkg/analyzer/lib/source/package_map_resolver.dart
index 80ce2e6d1ff5c7b16db7d4dfc151e02ad4b70116..7a2cc07ba301e5d1aad9c7aa396a77536656367b 100644
--- a/pkg/analyzer/lib/source/package_map_resolver.dart
+++ b/pkg/analyzer/lib/source/package_map_resolver.dart
@@ -77,21 +77,24 @@ class PackageMapUriResolver extends UriResolver {
@override
Uri restoreAbsolute(Source source) {
String sourcePath = source.fullName;
+ Uri bestMatch;
+ int bestMatchLength = -1;
for (String pkgName in packageMap.keys) {
List<Folder> pkgFolders = packageMap[pkgName];
for (int i = 0; i < pkgFolders.length; i++) {
Folder pkgFolder = pkgFolders[i];
String pkgFolderPath = pkgFolder.path;
// TODO(paulberry): figure out the right thing to do for Windows.
- if (sourcePath.startsWith(pkgFolderPath + '/')) {
+ if (pkgFolderPath.length > bestMatchLength && sourcePath.startsWith(pkgFolderPath + '/')) {
String relPath = sourcePath.substring(pkgFolderPath.length + 1);
if (_isReversibleTranslation(pkgFolders, i, relPath)) {
- return Uri.parse('$PACKAGE_SCHEME:$pkgName/$relPath');
+ bestMatch = Uri.parse('$PACKAGE_SCHEME:$pkgName/$relPath');
+ bestMatchLength = pkgFolderPath.length;
}
}
}
}
- return null;
+ return bestMatch;
}
/**
« no previous file with comments | « no previous file | pkg/analyzer/test/source/package_map_resolver_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698