Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1588)

Issue 953803004: Attempt to fix all.gyp again, take #2. (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Attempt to fix all.gyp again, take #2. The prior fix -- #317907 -- used "iOS" instead of "ios". The initial change disabled the "blink_tests" target, and also had a redundant conditions block. My first attempt at a fix fixed blink_tests, but typo'ed "iOS" instead of "ios", causing the iOS bots to pick up stuff that couldn't build, and fail. TBR=brettw@chromium.org NOTRY=true NOTREECHECKS=true Committed: https://chromium.googlesource.com/chromium/src/+/2f69645f3a92b8386435a17b13ff3b9e52bf01c8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -52 lines) Patch
M build/all.gyp View 2 chunks +48 lines, -52 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Dirk Pranke
5 years, 10 months ago (2015-02-24 23:10:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953803004/1
5 years, 10 months ago (2015-02-24 23:11:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2f69645f3a92b8386435a17b13ff3b9e52bf01c8 Cr-Commit-Position: refs/heads/master@{#317914}
5 years, 10 months ago (2015-02-24 23:24:48 UTC) #4
Dirk Pranke
5 years, 10 months ago (2015-02-24 23:24:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2f69645f3a92b8386435a17b13ff3b9e52bf01c8 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698