Issue 953803002: download_sdk_extras: Catch the correct error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 953803002: download_sdk_extras: Catch the correct error. (Closed)

Created:
5 years, 10 months ago by matthewyuan

Modified:
5 years, 10 months ago

Reviewers:
navabi1, hinoka

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2311

Target Ref:
refs/pending/branch-heads/2311

Project:
chromium

Visibility:
Public.

download_sdk_extras: Catch the correct error. Catch the error raised by 'check_call' rather than the error emitted by the called process. BUG=chromium:460693, chromium:459681 TEST=local - Ran without fix, setting CHROME_HEADLESS=1. Script failed with the exception in the bug. - Ran with fix, 'gsutil' failed with AccessDeniedException output and the calling script successfully emitted a warning message. R=hinoka@chromium.org, navabi@chromium.org Review URL: https://codereview.chromium.org/949813002 Cr-Commit-Position: refs/heads/master@{#317608} (cherry picked from commit 63ab4fead51b043cb1f21ae2b31f9e593cbdc3ca) Committed: https://chromium.googlesource.com/chromium/src/+/52e1248a93618e54a6c2be92360a9b47a0b823e4

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	build/download_sdk_extras.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 1 (0 generated)

matthewyuan

5 years, 10 months ago (2015-02-24 09:48:00 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
52e1248a93618e54a6c2be92360a9b47a0b823e4.