content/browser/loader/buffered_resource_handler.h - Issue 953793003: Ensuring interception of stream get determined by plugin path before checking mime type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/buffered_resource_handler.h

Issue 953793003: Ensuring interception of stream get determined by plugin path before checking mime type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc ('k') | content/browser/loader/buffered_resource_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/buffered_resource_handler.h

diff --git a/content/browser/loader/buffered_resource_handler.h b/content/browser/loader/buffered_resource_handler.h

index 4e80ec53bd58e9c731037c14fc10ac3af05b7099..e0a1388a7d578fb3ca6123a1ff43fffec2410c70 100644

--- a/content/browser/loader/buffered_resource_handler.h

+++ b/content/browser/loader/buffered_resource_handler.h

@@ -56,6 +56,11 @@ class CONTENT_EXPORT BufferedResourceHandler

bool ShouldSniffContent();

bool DetermineMimeType();

+ // Returns true if a plugin will handle the current request. |defer| is set

+ // to true if plugin data is stale and needs to be refreshed before the

+ // request can be handled. |request_handled| is false if the request should

+ // be cancelled and true otherwise.

+ bool IsHandledByPlugin(bool* defer, bool* request_handled);

bool SelectNextHandler(bool* defer);

bool UseAlternateNextHandler(scoped_ptr<ResourceHandler> handler,

const std::string& payload_for_old_handler);

@@ -64,7 +69,6 @@ class CONTENT_EXPORT BufferedResourceHandler

void CallReplayReadCompleted();

bool MustDownload();

- bool HasSupportingPlugin(bool* is_stale);

// Copies data from |read_buffer_| to |next_handler_|.

bool CopyReadBufferToNextHandler();