Ensuring interception of stream get determined by plugin path before checking mime type.

content/browser/loader/buffered_resource_handler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/buffered_resource_handler.h"
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/scoped_ptr.h"
 #include "content/browser/loader/resource_dispatcher_host_impl.h"
@@ skipping 81 matching lines @@
       net::URLRequest* request,
       bool is_content_initiated,
       bool must_download,
       uint32 id,
       scoped_ptr<DownloadSaveInfo> save_info,
       const DownloadUrlParameters::OnStartedCallback& started_cb) override {
     return scoped_ptr<ResourceHandler>(new TestResourceHandler).Pass();
   }
 
   scoped_ptr<ResourceHandler> MaybeInterceptAsStream(
+      const base::FilePath& file_path,

[raymes, 2015/03/12 05:21:03]

plugin_path

[Deepak, 2015/03/12 12:33:18]

Done.

       net::URLRequest* request,
       ResourceResponse* response,
       std::string* payload) override {
     if (stream_has_handler_) {
       intercepted_as_stream_ = true;
       return scoped_ptr<ResourceHandler>(new TestResourceHandler).Pass();
     } else {
       return scoped_ptr<ResourceHandler>();
     }
   }
@@ skipping 99 matching lines @@
   bool defer = false;
   buffered_handler->OnResponseStarted(response.get(), &defer);
 
   content::RunAllPendingInMessageLoop();
 
   return host.intercepted_as_stream();
 }
 
 // Test that stream requests are correctly intercepted under the right
 // circumstances.
 TEST_F(BufferedResourceHandlerTest, StreamHandling) {

[raymes, 2015/03/12 05:21:03]

Does this test pass now? I would have expected this file to need some changes?

[Deepak, 2015/03/12 12:33:18]

I have run all content_unittests, All the test cases are getting passed.

   bool allow_download;
   bool must_download;
   ResourceType resource_type;
 
   // Ensure the stream is handled by MaybeInterceptAsStream in the
   // ResourceDispatcherHost.
   set_stream_has_handler(true);
 
   // Main frame request with no download allowed. Stream shouldn't be
   // intercepted.
@@ skipping 45 matching lines @@
   allow_download = true;
   must_download = false;
   resource_type = RESOURCE_TYPE_MAIN_FRAME;
   EXPECT_FALSE(
       TestStreamIsIntercepted(allow_download, must_download, resource_type));
 }
 
 }  // namespace
 
 }  // namespace content