Ensuring interception of stream get determined by plugin path before checking mime type.

chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/chrome_resource_dispatcher_host_delegate.h"
 
 #include <string>
 #include <vector>
 
 #include "base/base64.h"
@@ skipping 192 matching lines @@
   Profile* profile =
       Profile::FromBrowserContext(web_contents->GetBrowserContext());
 
   StreamsPrivateAPI* streams_private = StreamsPrivateAPI::Get(profile);
   if (!streams_private)
     return;
   streams_private->ExecuteMimeTypeHandler(
       extension_id, web_contents, stream.Pass(), view_id, expected_content_size,
       embedded, render_process_id, render_frame_id);
 }
-
-// TODO(raymes): This won't return the right result if plugins haven't been
-// loaded yet. Fixing this properly really requires fixing crbug.com/443466.
-bool IsPluginEnabledForExtension(const Extension* extension,
-                                 const ResourceRequestInfo* info,
-                                 const std::string& mime_type,
-                                 const GURL& url) {
-  content::PluginService* service = content::PluginService::GetInstance();
-  std::vector<content::WebPluginInfo> plugins;
-  service->GetPluginInfoArray(url, mime_type, true, &plugins, nullptr);
-  content::PluginServiceFilter* filter = service->GetFilter();
-
-  for (auto& plugin : plugins) {
-    // Check that the plugin is running the extension.
-    if (plugin.path !=
-        base::FilePath::FromUTF8Unsafe(extension->url().spec())) {
-      continue;
-    }
-    // Check that the plugin is actually enabled.
-    if (!filter || filter->IsPluginAvailable(info->GetChildID(),
-                                             info->GetRenderFrameID(),
-                                             info->GetContext(),
-                                             url,
-                                             GURL(),
-                                             &plugin)) {
-      return true;
-    }
-  }
-  return false;
-}
 #endif  // !defined(ENABLE_EXTENSIONS)
 
 #if !defined(OS_ANDROID)
 void LaunchURL(const GURL& url, int render_process_id, int render_view_id) {
   // If there is no longer a WebContents, the request may have raced with tab
   // closing. Don't fire the external request. (It may have been a prerender.)
   content::WebContents* web_contents =
       tab_util::GetWebContentsByID(render_process_id, render_view_id);
   if (!web_contents)
     return;
@@ skipping 368 matching lines @@
     const GURL& url, const std::string& mime_type) {
 #if defined(ENABLE_EXTENSIONS)
   // Special-case user scripts to get downloaded instead of viewed.
   return extensions::UserScript::IsURLUserScript(url, mime_type);
 #else
   return false;
 #endif
 }
 
 bool ChromeResourceDispatcherHostDelegate::ShouldInterceptResourceAsStream(
+    const base::FilePath& file_path,

[raymes, 2015/03/12 05:21:03]

plugin_path

     net::URLRequest* request,
     const std::string& mime_type,
     GURL* origin,
     std::string* payload) {
 #if defined(ENABLE_EXTENSIONS)
   const ResourceRequestInfo* info = ResourceRequestInfo::ForRequest(request);
   ProfileIOData* io_data =
       ProfileIOData::FromResourceContext(info->GetContext());
   bool profile_is_off_the_record = io_data->IsOffTheRecord();
   const scoped_refptr<const extensions::InfoMap> extension_info_map(
       io_data->GetExtensionInfoMap());
   std::vector<std::string> whitelist = MimeTypesHandler::GetMIMETypeWhitelist();
+
+  content::PluginService* service = content::PluginService::GetInstance();
+  content::PluginServiceFilter* filter = service->GetFilter();

[raymes, 2015/03/12 05:21:03]

We can remove the above 2 lines (see below)

   // Go through the white-listed extensions and try to use them to intercept
   // the URL request.
   for (size_t i = 0; i < whitelist.size(); ++i) {
     const char* extension_id = whitelist[i].c_str();
     const Extension* extension =
         extension_info_map->extensions().GetByID(extension_id);
     // The white-listed extension may not be installed, so we have to NULL check
     // |extension|.
     if (!extension ||
         (profile_is_off_the_record &&
          !extension_info_map->IsIncognitoEnabled(extension_id))) {
       continue;
     }
 
-    MimeTypesHandler* handler = MimeTypesHandler::GetHandler(extension);
-    if (handler && handler->CanHandleMIMEType(mime_type)) {
+    if (file_path == base::FilePath::FromUTF8Unsafe(extension->url().spec())) {
       StreamTargetInfo target_info;
       *origin = Extension::GetBaseURLFromExtensionId(extension_id);
       target_info.extension_id = extension_id;
-      if (!handler->handler_url().empty()) {
-        // This is reached in the case of MimeHandlerViews. If the
-        // MimeHandlerView plugin is disabled, then we shouldn't intercept the
-        // stream.
-        if (!IsPluginEnabledForExtension(extension, info, mime_type,
-                                         request->url())) {
+
+      content::WebPluginInfo plugin;
+      bool plugin_info = service->GetPluginInfoByPath(file_path, &plugin);
+      // Check that the plugin is actually enabled.

[raymes, 2015/03/12 05:21:03]

We don't need to check if it's enabled. This check will already be performed
before we get here. We can delete this.

+      // MimeHandlerView plugin is disabled, then we shouldn't intercept the
+      // stream.
+      if (!plugin_info && filter &&
+          !filter->IsPluginAvailable(
+              info->GetChildID(), info->GetRenderFrameID(), info->GetContext(),
+              request->url(), GURL(), &plugin)) {
           continue;
-        }
-        target_info.view_id = base::GenerateGUID();
-        *payload = target_info.view_id;
       }

[raymes, 2015/03/12 05:21:03]

I think we can add a DCHECK in this case:
DCHECK(!handler->handler_url().empty());

+      target_info.view_id = base::GenerateGUID();
+      *payload = target_info.view_id;
       stream_target_info_[request] = target_info;
       return true;
+    } else {
+      MimeTypesHandler* handler = MimeTypesHandler::GetHandler(extension);
+      if (handler && handler->CanHandleMIMEType(mime_type)) {
+        StreamTargetInfo target_info;
+        *origin = Extension::GetBaseURLFromExtensionId(extension_id);
+        target_info.extension_id = extension_id;
+        if (!handler->handler_url().empty()) {

[raymes, 2015/03/12 05:21:03]

In this case we should be able to remove this if-statement and turn it into the
opposite DCHECK:
DCHECK(handler->handler_url().empty());

+          target_info.view_id = base::GenerateGUID();
+          *payload = target_info.view_id;

[raymes, 2015/03/12 05:21:03]

We can remove the above 2 lines here, they should never be hit.

+        }
+        stream_target_info_[request] = target_info;
+        return true;
+      }
     }
   }
 #endif
   return false;
 }
 
 void ChromeResourceDispatcherHostDelegate::OnStreamCreated(
     net::URLRequest* request,
     scoped_ptr<content::StreamInfo> stream) {
 #if defined(ENABLE_EXTENSIONS)
@@ skipping 122 matching lines @@
                                        url_request->GetTotalReceivedBytes()));
   }
 }
 
 // static
 void ChromeResourceDispatcherHostDelegate::
     SetExternalProtocolHandlerDelegateForTesting(
     ExternalProtocolHandler::Delegate* delegate) {
   g_external_protocol_handler_delegate = delegate;
 }