Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 953793002: Oilpan: improve fast/workers/worker-document-leak.html stability. (Closed)

Created:
5 years, 10 months ago by sof
Modified:
5 years, 10 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: improve fast/workers/worker-document-leak.html stability. Remove (one) fast/workers/ gc() definition, relying instead on the js-test.js version, which performs the more thorough GCController.collectAll(). R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -31 lines) Patch
M LayoutTests/fast/workers/resources/worker-util.js View 2 chunks +1 line, -19 lines 0 comments Download
M LayoutTests/fast/workers/shared-worker-lifecycle.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/workers/worker-document-leak.html View 4 chunks +14 lines, -11 lines 0 comments Download
M LayoutTests/fast/workers/worker-document-leak-expected.txt View 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 12 (6 generated)
sof
Please take a look.
5 years, 10 months ago (2015-02-24 09:53:00 UTC) #2
haraken
LGTM
5 years, 10 months ago (2015-02-24 09:56:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953793002/1
5 years, 10 months ago (2015-02-24 10:54:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953793002/1
5 years, 10 months ago (2015-02-24 11:53:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953793002/1
5 years, 10 months ago (2015-02-24 12:16:48 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 14:57:36 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190756

Powered by Google App Engine
This is Rietveld 408576698