Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 953723004: Convert pdfium expected test results to PNG format. (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert pdfium expected test results to PNG format. Required to save space vs. raw bitmap. Land prior to adding substantial number of tests. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/23f92886e05a187c1755dd6878960fcbc23b3e97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
A testing/resources/pixel/font_size_expected.pdf.0.png View Binary file 0 comments Download
D testing/resources/pixel/font_size_expected.pdf.0.ppm View Binary file 0 comments Download
M testing/tools/run_pixel_tests.py View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, please review when you get a chance. Should be small.
5 years, 10 months ago (2015-02-24 18:32:52 UTC) #2
Lei Zhang
lgtm
5 years, 10 months ago (2015-02-24 20:24:35 UTC) #3
Tom Sepez
5 years, 10 months ago (2015-02-24 20:31:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
23f92886e05a187c1755dd6878960fcbc23b3e97 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698