InlinedVisitor: Migrate css to use inlined tracing

InlinedVisitor: Migrate css to use inlined tracing

Updates trace methods as of https://groups.google.com/a/chromium.org/d/msg/blink-dev/oi4Snt9jNx8/XcES55c7QaQJ

R=oilpan-reviews
BUG=455524
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=190726

[tkent, 2015-02-24 08:34:38]

tkent@chromium.org changed reviewers:
+ tkent@chromium.org

[tkent, 2015-02-24 08:34:38]

The CQ bit was checked by tkent@chromium.org

[tkent, 2015-02-24 08:34:39]

lgtm

[commit-bot: I haz the power, 2015-02-24 08:35:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/953693002/1

[commit-bot: I haz the power, 2015-02-24 08:41:38]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=190726

[haraken, 2015-02-24 09:08:50]

haraken@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2015-02-24 09:08:52]

LGTM.

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSBorderIma...
File Source/core/css/CSSBorderImageSliceValue.h (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSBorderIma...
Source/core/css/CSSBorderImageSliceValue.h:48: DECLARE_TRACE_AFTER_DISPATCH();

BTW, do we need both traceImpl and traceAfterDispatch? They are doing similar
things in a sense that they implement custom trace methods that are called after
the default trace method. Can we use the same name for them?

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSGroupingR...
File Source/core/css/CSSGroupingRule.cpp (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSGroupingR...
Source/core/css/CSSGroupingRule.cpp:158: CSSRule::trace(visitor);

Make this a tail call.

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSKeyframes...
File Source/core/css/CSSKeyframesRule.cpp (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSKeyframes...
Source/core/css/CSSKeyframesRule.cpp:213: CSSRule::trace(visitor);

Make this a tail call.

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSRule.cpp
File Source/core/css/CSSRule.cpp (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSRule.cpp#...
Source/core/css/CSSRule.cpp:53: #if ENABLE(OILPAN)

BTW, when you remove '#if ENABLE(OILPAN)' from trace methods, you need to be
careful about this -- you can't remove this #if ENABLE(OILPAN).

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSValue.h
File Source/core/css/CSSValue.h (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSValue.h#n...
Source/core/css/CSSValue.h:92: DEFINE_INLINE_TRACE_AFTER_DISPATCH() { }

We should probably have a comment on why we need traceAfterDispatch for the
CSSValue hierarchy.

https://codereview.chromium.org/953693002/diff/1/Source/core/css/MediaList.cpp
File Source/core/css/MediaList.cpp (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/MediaList.cp...
Source/core/css/MediaList.cpp:169: // We don't support tracing of vectors of
OwnPtrs (ie. OwnPtr<Vector<OwnPtr<MediaQuery> > >).

Remove the comment.

https://codereview.chromium.org/953693002/diff/1/Source/core/css/MediaQuery.cpp
File Source/core/css/MediaQuery.cpp (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/MediaQuery.c...
Source/core/css/MediaQuery.cpp:138: // We don't support tracing of vectors of
OwnPtrs (ie. OwnPtr<Vector<OwnPtr<MediaQuery> > >).

Remove the comment.

[haraken, 2015-03-03 15:34:38]

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSRule.cpp
File Source/core/css/CSSRule.cpp (right):

https://codereview.chromium.org/953693002/diff/1/Source/core/css/CSSRule.cpp#...
Source/core/css/CSSRule.cpp:53: #if ENABLE(OILPAN)
On 2015/02/24 09:08:52, haraken wrote:
> 
> BTW, when you remove '#if ENABLE(OILPAN)' from trace methods, you need to be
> careful about this -- you can't remove this #if ENABLE(OILPAN).

Ignore this comment. These parent pointers are raw pointers in non-oilpan
builds, it's safe to just remove #if ENABLE(OILPAN).