Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 953673002: Delete RenderLayerModelObject. (Closed)

Created:
5 years, 10 months ago by ojan
Modified:
5 years, 10 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Delete RenderLayerModelObject. Merge most of it into RenderBox. Only RenderBoxes can have layers now. This also meant a bit of code could be cleaned up since some virtuals (e.g. updateFromStyle) are no longer needed since they're only called on RenderBoxes. collectSelfPaintingLayers is the only bit that's moved into RenderBoxModelObject instead of RenderBox. That's because we need to be able to recurse down into RenderInlines since they may contain RenderBoxes that have selfPaintingLayers. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dc6845c48cb35e0897659096650e2a8bd7d2a2d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -359 lines) Patch
M sky/engine/core/core.gni View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/InlineFlowBox.cpp View 5 chunks +12 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/PaintInfo.h View 3 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 7 chunks +18 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 7 chunks +63 lines, -9 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.h View 5 chunks +6 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 6 chunks +19 lines, -21 lines 0 comments Download
M sky/engine/core/rendering/RenderGeometryMap.h View 3 chunks +6 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderGeometryMap.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 3 chunks +2 lines, -6 lines 0 comments Download
M sky/engine/core/rendering/RenderInline.cpp View 4 chunks +4 lines, -18 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.h View 5 chunks +8 lines, -7 lines 0 comments Download
M sky/engine/core/rendering/RenderLayer.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerClipper.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
D sky/engine/core/rendering/RenderLayerModelObject.h View 1 chunk +0 lines, -77 lines 0 comments Download
D sky/engine/core/rendering/RenderLayerModelObject.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNode.h View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderLayerStackingNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderObject.h View 7 chunks +12 lines, -13 lines 0 comments Download
M sky/engine/core/rendering/RenderObject.cpp View 16 chunks +20 lines, -20 lines 0 comments Download
M sky/engine/core/rendering/RenderView.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderView.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
abarth-chromium
lgtm
5 years, 10 months ago (2015-02-24 01:04:51 UTC) #2
ojan
5 years, 10 months ago (2015-02-24 01:24:44 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dc6845c48cb35e0897659096650e2a8bd7d2a2d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698