Issue 953543002: Remove PopupItemType.template

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 953543002: Remove PopupItemType.template (Closed)

Created:
5 years, 10 months ago by Peter Beverloo

Modified:
5 years, 10 months ago

Reviewers:
Yaron, yfriedman

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove PopupItemType.template This Android-specific file isn't used anywhere anymore. Came up while reviewing Daniel's CL: https://codereview.chromium.org/952443004/ BUG= Committed: https://crrev.com/c0f47557dd9c3a8d6a4373d570178437a88b8db7 Cr-Commit-Position: refs/heads/master@{#317613}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	D	content/public/android/java/src/org/chromium/content/browser/input/PopupItemType.template	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Total messages: 7 (2 generated)

Yaron

On 2015/02/23 17:39:47, Peter Beverloo wrote: > +yfriedman who is back \o/ lgtm

5 years, 10 months ago (2015-02-23 18:17:25 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953543002/1

5 years, 10 months ago (2015-02-23 18:26:45 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-23 18:50:17 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c0f47557dd9c3a8d6a4373d570178437a88b8db7
Cr-Commit-Position: refs/heads/master@{#317613}