Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1354)

Unified Diff: build/jar_file_jni_generator.gypi

Issue 953523003: Make combined native/manual JNI registration work for clang. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/jar_file_jni_generator.gypi
diff --git a/build/jar_file_jni_generator.gypi b/build/jar_file_jni_generator.gypi
index 9472c10be4035acf85209f60648681147304b0e3..6f5d2f1bfc23555c5aa147bfdb265ba0442b7d6d 100644
--- a/build/jar_file_jni_generator.gypi
+++ b/build/jar_file_jni_generator.gypi
@@ -26,7 +26,7 @@
'jni_generator_includes%': (
'base/android/jni_generator/jni_generator_helper.h'
),
- 'native_exports%': '',
+ 'native_exports%': '--native_exports_optional',
},
'actions': [
{
@@ -73,13 +73,5 @@
'<(DEPTH)/build/android/android_exports.gyp:android_exports',
],
}],
- ['clang==0', {
- # Clang builds currently fail with --native_exports_optional due to
- # http://llvm.org/bugs/show_bug.cgi?id=22602 - only enable for gcc.
- # http://crbug.com/442327
- 'variables': {
- 'native_exports%': '--native_exports_optional',
- },
- }],
],
}

Powered by Google App Engine
This is Rietveld 408576698