Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(884)

Unified Diff: services/http_server/public/http_server_factory.mojom

Issue 953513002: http_server: accept full NetAddress in CreateHttpServer. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Address Ben's comments. Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/http_server/public/BUILD.gn ('k') | sky/tools/debugger/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/http_server/public/http_server_factory.mojom
diff --git a/services/http_server/public/http_server_factory.mojom b/services/http_server/public/http_server_factory.mojom
index f0af8744cc3c7a5539c0de06bf19841f6ee0a6f0..3395fa0c50e1d560f1358d74977198ca3a5f142f 100644
--- a/services/http_server/public/http_server_factory.mojom
+++ b/services/http_server/public/http_server_factory.mojom
@@ -4,19 +4,24 @@
module http_server;
+import "mojo/services/network/public/interfaces/net_address.mojom";
import "services/http_server/public/http_server.mojom";
interface HttpServerFactory {
- // Creates an http server running on the specified TCP port. If |port| is 0,
- // the operating system will pick one of available ports. You can use
- // HttpServer::GetPort() to retrieve the allocated port.
+ // Creates an http server running on the specified local network address. If
+ // |local_address| is null, it will take the default value of 0.0.0.0 at a
+ // system-allocated port.
//
- // Only one backing server will be created for each port. It will be shared
- // among clients, if more than one client requests a server running on a
- // particular port.
+ // Note that the port value of 0 means that the operating system will pick
+ // one of available ports. You can use HttpServer::GetPort() to retrieve the
+ // allocated port.
+ //
+ // Only one backing server will be created for each local network address. It
+ // will be shared among clients, if more than one client requests a server
+ // running on a particular network address.
//
// TODO(ppi): would it be better to create a server only for the first caller
// and require the access to it to be explicitly shared by the party that
// requests it first?
- CreateHttpServer(HttpServer& server_request, uint16 port);
+ CreateHttpServer(HttpServer& server_request, mojo.NetAddress? local_address);
};
« no previous file with comments | « services/http_server/public/BUILD.gn ('k') | sky/tools/debugger/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698