Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
953493002:
New port: nettle (Closed)
|
Created:
5 years, 10 months ago by cschuet (SLOW) Modified:
5 years, 8 months ago CC:
native-client-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/external/naclports.git@master Target Ref:
refs/heads/master Project:
naclports Visibility:
Public. |
DescriptionNew port: nettle
This is a complete port of nettle, a low-level cryptographic
library, except for the examples. Examples failed to build on
clang toolchain with an internal compiler error. We are
porting nettle 2.7 rather than 3.0 since gnutls does not
build against 3.0.
TEST=./build_all.sh nettle
Committed: https://chromium.googlesource.com/external/naclports/+/e251f3712daa04222238ae7dc3a5ea849b6e3fda
Patch Set 1 #Patch Set 2 : reenabled assembler #Patch Set 3 : use nettle 2.7 as gnutls does not build against 3.0 #Patch Set 4 : added dependency on gmp to make nettle build libhogweed (needed by gnutls) #
Total comments: 4
Patch Set 5 : addressed sbc's comments #Patch Set 6 : disable assembly and add executables in build.sh #
Total comments: 1
Patch Set 7 : updated patch #
Messages
Total messages: 59 (21 generated)
cschuet@chromium.org changed reviewers: + bartfab@chromium.org, sbc@chromium.org, sbc@google.com
ptal
nit: can you wrap the commit message (72 chars is normal)? Also, can you mention in the commit message why you are not porting 3.0 (BTW, is there an API/ABI breaking?). Also, can you add a 'TEST=./build_all.sh nettle' line to the commit message and make sure that command runs. You might also want to run the trybots with 'git cl try'. Other than that lgtm. I'll add the nettle tar archive to our mirror now. https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh File ports/nettle/build.sh (right): https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh#ne... ports/nettle/build.sh:1: #!/bin/bash Drop the #!, these script aren't runnable on their own. https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh#ne... ports/nettle/build.sh:6: if [ "${NACL_LIBC}" = "newlib" ]; then "${NACL_SHARED}" != "1"
On 2015/02/23 17:17:33, Sam Clegg wrote: > nit: can you wrap the commit message (72 chars is normal)? > > Also, can you mention in the commit message why you > are not porting 3.0 (BTW, is there an API/ABI breaking?). > > Also, can you add a 'TEST=./build_all.sh nettle' line to > the commit message and make sure that command runs. You > might also want to run the trybots with 'git cl try'. > > Other than that lgtm. I'll add the nettle tar archive to > our mirror now. > > https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh > File ports/nettle/build.sh (right): > > https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh#ne... > ports/nettle/build.sh:1: #!/bin/bash > Drop the #!, these script aren't runnable on their own. > > https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh#ne... > ports/nettle/build.sh:6: if [ "${NACL_LIBC}" = "newlib" ]; then > "${NACL_SHARED}" != "1" Done. I don't know exactly what the problem is, but it seems that they are planning to become nettle 3.0 compatible in gnutls 3.4, i.e. see https://www.gitorious.org/gnutls/pages/Plan3_4
The CQ bit was checked by cschuet@chromium.org
The CQ bit was unchecked by cschuet@chromium.org
New patchsets have been uploaded after l-g-t-m from sbc@chromium.org
build.sh modifications done. https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh File ports/nettle/build.sh (right): https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh#ne... ports/nettle/build.sh:1: #!/bin/bash On 2015/02/23 17:17:33, Sam Clegg wrote: > Drop the #!, these script aren't runnable on their own. Done. https://codereview.chromium.org/953493002/diff/60001/ports/nettle/build.sh#ne... ports/nettle/build.sh:6: if [ "${NACL_LIBC}" = "newlib" ]; then On 2015/02/23 17:17:33, Sam Clegg wrote: > "${NACL_SHARED}" != "1" Done.
lgtm
Disabling assembly was necessary to make the executables verify and translate.
lgtm. I added you to the committer list so you should be able to run "git cl land" when you are ready. https://codereview.chromium.org/953493002/diff/100001/ports/nettle/build.sh File ports/nettle/build.sh (right): https://codereview.chromium.org/953493002/diff/100001/ports/nettle/build.sh#n... ports/nettle/build.sh:12: ./tools/sexp-conv${NACL_EXEEXT} Drop the "./" prefix.
The CQ bit was checked by cschuet@chromium.org
The CQ bit was unchecked by sergiyb@chromium.org
sergiyb@chromium.org changed reviewers: + sergiyb@chromium.org
Currently, there is no naclports CQ for naclports project. Please land this change manually.
On 2015/03/23 10:03:37, Sergiy Byelozyorov wrote: > Currently, there is no naclports CQ for naclports project. Please land this > change manually. Actually, I've just enabled naclports CQ, so I'm re-checking CQ bit on this CL to test if naclports CQ works correctly.
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/100001
On 2015/03/23 12:41:59, I haz the power (commit-bot) wrote: > CQ is trying da patch. Follow status at > https://chromium-cq-status.appspot.com/patch-status/953493002/100001 naclports CQ is broken right now, so if you need to land this, please do it manually. The CL that will (hopefully) fix CQ is here: https://codereview.chromium.org/1025453005.
The CQ bit was unchecked by sergiyb@chromium.org
On 2015/03/23 15:13:38, Sergiy Byelozyorov wrote: > On 2015/03/23 12:41:59, I haz the power (commit-bot) wrote: > > CQ is trying da patch. Follow status at > > https://chromium-cq-status.appspot.com/patch-status/953493002/100001 > > naclports CQ is broken right now, so if you need to land this, please do it > manually. > The CL that will (hopefully) fix CQ is here: > https://codereview.chromium.org/1025453005. CQ was fixed. Trying to land this again...
The CQ bit was checked by sergiyb@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: naclports-linux-glibc-2 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-2/b...)
On 2015/03/24 01:46:45, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > naclports-linux-glibc-2 on tryserver.nacl (JOB_FAILED, > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-2/b...) Is the CQ still broken then?
The CQ bit was checked by sergiyb@chromium.org
The CQ bit was unchecked by sergiyb@chromium.org
On 2015/04/01 14:32:37, bartfab wrote: > On 2015/03/24 01:46:45, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > naclports-linux-glibc-2 on tryserver.nacl (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-2/b...) > > Is the CQ still broken then? No, it should be working. I'll investigate.
On 2015/04/01 14:36:17, Sergiy Byelozyorov wrote: > On 2015/04/01 14:32:37, bartfab wrote: > > On 2015/03/24 01:46:45, I haz the power (commit-bot) wrote: > > > Try jobs failed on following builders: > > > naclports-linux-glibc-2 on tryserver.nacl (JOB_FAILED, > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-glibc-2/b...) > > > > Is the CQ still broken then? > > No, it should be working. I'll investigate. That just looks like test flake. Sorry. Please try again.
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...)
On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > Try jobs failed on following builders: > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) Looks like that patch failed to apply...
On 2015/04/01 23:52:19, Sam Clegg wrote: > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > Try jobs failed on following builders: > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > Looks like that patch failed to apply... Sorry, I haven't had time to look at this yesterday. I will try to find tume later today.
On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > On 2015/04/01 23:52:19, Sam Clegg wrote: > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > Try jobs failed on following builders: > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > Looks like that patch failed to apply... > > Sorry, I haven't had time to look at this yesterday. I will try to find tume > later today. Indeed looks like a patch failure. Can you please verify that the patch still applies?
On 2015/04/02 09:17:42, Sergiy Byelozyorov wrote: > On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > > On 2015/04/01 23:52:19, Sam Clegg wrote: > > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > > Try jobs failed on following builders: > > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > > > Looks like that patch failed to apply... > > > > Sorry, I haven't had time to look at this yesterday. I will try to find tume > > later today. > > Indeed looks like a patch failure. Can you please verify that the patch still > applies? Running "./make_all.sh nettle" correctly builds the target for all nacl platforms. I am on the newest version of the nacl_sdk. Do you have any idea what could be going wrong here?
On 2015/04/02 13:03:50, cschuet wrote: > On 2015/04/02 09:17:42, Sergiy Byelozyorov wrote: > > On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > > > On 2015/04/01 23:52:19, Sam Clegg wrote: > > > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > > > Try jobs failed on following builders: > > > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > > > > > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > > > > > Looks like that patch failed to apply... > > > > > > Sorry, I haven't had time to look at this yesterday. I will try to find tume > > > later today. > > > > Indeed looks like a patch failure. Can you please verify that the patch still > > applies? > > Running "./make_all.sh nettle" correctly builds the target for all nacl > platforms. I am on the newest version of the nacl_sdk. Do you have any idea what > could be going wrong here? I know very little about nacports to tell what "nettle" or "make_all.sh" is. What I see from this log (http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...) is that the patch from this CL (presumably) does not apply to the source, which is downloaded from http://storage.googleapis.com/naclports/mirror/nettle-2.7.tar.gz. The log actually prints all commands, so you can run them locally to reproduce. Most likely you need to rebase your code.
On 2015/04/02 14:30:35, Sergiy Byelozyorov wrote: > On 2015/04/02 13:03:50, cschuet wrote: > > On 2015/04/02 09:17:42, Sergiy Byelozyorov wrote: > > > On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > > > > On 2015/04/01 23:52:19, Sam Clegg wrote: > > > > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > > > > Try jobs failed on following builders: > > > > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > > > > > > > > > > > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > > > > > > > Looks like that patch failed to apply... > > > > > > > > Sorry, I haven't had time to look at this yesterday. I will try to find > tume > > > > later today. > > > > > > Indeed looks like a patch failure. Can you please verify that the patch > still > > > applies? > > > > Running "./make_all.sh nettle" correctly builds the target for all nacl > > platforms. I am on the newest version of the nacl_sdk. Do you have any idea > what > > could be going wrong here? > > I know very little about nacports to tell what "nettle" or "make_all.sh" is. > What I see from this log > (http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...) > is that the patch from this CL (presumably) does not apply to the source, which > is downloaded from > http://storage.googleapis.com/naclports/mirror/nettle-2.7.tar.gz. The log > actually prints all commands, so you can run them locally to reproduce. Most > likely you need to rebase your code. Hm. This is strange. I tried to reproduce it and it applied just fine. I've only then realized that this patch is only adding new files, so there can't be any conflicts. This means that step 'clang-newlib nettle' gets the patch from somewhere else.
On 2015/04/02 14:37:35, Sergiy Byelozyorov wrote: > On 2015/04/02 14:30:35, Sergiy Byelozyorov wrote: > > On 2015/04/02 13:03:50, cschuet wrote: > > > On 2015/04/02 09:17:42, Sergiy Byelozyorov wrote: > > > > On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > > > > > On 2015/04/01 23:52:19, Sam Clegg wrote: > > > > > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > > > > > Try jobs failed on following builders: > > > > > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > > > > > > > > > Looks like that patch failed to apply... > > > > > > > > > > Sorry, I haven't had time to look at this yesterday. I will try to find > > tume > > > > > later today. > > > > > > > > Indeed looks like a patch failure. Can you please verify that the patch > > still > > > > applies? > > > > > > Running "./make_all.sh nettle" correctly builds the target for all nacl > > > platforms. I am on the newest version of the nacl_sdk. Do you have any idea > > what > > > could be going wrong here? > > > > I know very little about nacports to tell what "nettle" or "make_all.sh" is. > > What I see from this log > > > (http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...) > > is that the patch from this CL (presumably) does not apply to the source, > which > > is downloaded from > > http://storage.googleapis.com/naclports/mirror/nettle-2.7.tar.gz. The log > > actually prints all commands, so you can run them locally to reproduce. Most > > likely you need to rebase your code. > > Hm. This is strange. I tried to reproduce it and it applied just fine. I've only > then realized that this patch is only adding new files, so there can't be any > conflicts. This means that step 'clang-newlib nettle' gets the patch from > somewhere else. yes, the patch in question is the 'nacl.patch' which is part of the CL... a patch within a patch if you like. Can you try "rm -rf out/build/nettle".. then "make nettle F=1 V=1".
On 2015/04/02 15:38:44, Sam Clegg wrote: > On 2015/04/02 14:37:35, Sergiy Byelozyorov wrote: > > On 2015/04/02 14:30:35, Sergiy Byelozyorov wrote: > > > On 2015/04/02 13:03:50, cschuet wrote: > > > > On 2015/04/02 09:17:42, Sergiy Byelozyorov wrote: > > > > > On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > > > > > > On 2015/04/01 23:52:19, Sam Clegg wrote: > > > > > > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > > > > > > Try jobs failed on following builders: > > > > > > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > > > > > > > > > > > Looks like that patch failed to apply... > > > > > > > > > > > > Sorry, I haven't had time to look at this yesterday. I will try to > find > > > tume > > > > > > later today. > > > > > > > > > > Indeed looks like a patch failure. Can you please verify that the patch > > > still > > > > > applies? > > > > > > > > Running "./make_all.sh nettle" correctly builds the target for all nacl > > > > platforms. I am on the newest version of the nacl_sdk. Do you have any > idea > > > what > > > > could be going wrong here? > > > > > > I know very little about nacports to tell what "nettle" or "make_all.sh" is. > > > What I see from this log > > > > > > (http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...) > > > is that the patch from this CL (presumably) does not apply to the source, > > which > > > is downloaded from > > > http://storage.googleapis.com/naclports/mirror/nettle-2.7.tar.gz. The log > > > actually prints all commands, so you can run them locally to reproduce. Most > > > likely you need to rebase your code. > > > > Hm. This is strange. I tried to reproduce it and it applied just fine. I've > only > > then realized that this patch is only adding new files, so there can't be any > > conflicts. This means that step 'clang-newlib nettle' gets the patch from > > somewhere else. > > yes, the patch in question is the 'nacl.patch' which is part of the CL... a > patch within a patch if you like. > > Can you try "rm -rf out/build/nettle".. then "make nettle F=1 V=1". ... Build complete [took 16s] It seems that worked.
On 2015/04/02 15:46:21, cschuet wrote: > On 2015/04/02 15:38:44, Sam Clegg wrote: > > On 2015/04/02 14:37:35, Sergiy Byelozyorov wrote: > > > On 2015/04/02 14:30:35, Sergiy Byelozyorov wrote: > > > > On 2015/04/02 13:03:50, cschuet wrote: > > > > > On 2015/04/02 09:17:42, Sergiy Byelozyorov wrote: > > > > > > On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > > > > > > > On 2015/04/01 23:52:19, Sam Clegg wrote: > > > > > > > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > > > > > > > Try jobs failed on following builders: > > > > > > > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > > > > > > > > > > > > > Looks like that patch failed to apply... > > > > > > > > > > > > > > Sorry, I haven't had time to look at this yesterday. I will try to > > find > > > > tume > > > > > > > later today. > > > > > > > > > > > > Indeed looks like a patch failure. Can you please verify that the > patch > > > > still > > > > > > applies? > > > > > > > > > > Running "./make_all.sh nettle" correctly builds the target for all nacl > > > > > platforms. I am on the newest version of the nacl_sdk. Do you have any > > idea > > > > what > > > > > could be going wrong here? > > > > > > > > I know very little about nacports to tell what "nettle" or "make_all.sh" > is. > > > > What I see from this log > > > > > > > > > > (http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...) > > > > is that the patch from this CL (presumably) does not apply to the source, > > > which > > > > is downloaded from > > > > http://storage.googleapis.com/naclports/mirror/nettle-2.7.tar.gz. The log > > > > actually prints all commands, so you can run them locally to reproduce. > Most > > > > likely you need to rebase your code. > > > > > > Hm. This is strange. I tried to reproduce it and it applied just fine. I've > > only > > > then realized that this patch is only adding new files, so there can't be > any > > > conflicts. This means that step 'clang-newlib nettle' gets the patch from > > > somewhere else. > > > > yes, the patch in question is the 'nacl.patch' which is part of the CL... a > > patch within a patch if you like. > > > > Can you try "rm -rf out/build/nettle".. then "make nettle F=1 V=1". > > ... > Build complete [took 16s] > > It seems that worked. Hmm.. looks like the patch requires some fuzzing to apply. Could be difference between the git versions we are running. Can you try running 'naclports updatepatch nettle' and then re-upload?
Patchset #7 (id:120001) has been deleted
Patchset #7 (id:140001) has been deleted
On 2015/04/02 15:50:47, Sam Clegg wrote: > On 2015/04/02 15:46:21, cschuet wrote: > > On 2015/04/02 15:38:44, Sam Clegg wrote: > > > On 2015/04/02 14:37:35, Sergiy Byelozyorov wrote: > > > > On 2015/04/02 14:30:35, Sergiy Byelozyorov wrote: > > > > > On 2015/04/02 13:03:50, cschuet wrote: > > > > > > On 2015/04/02 09:17:42, Sergiy Byelozyorov wrote: > > > > > > > On 2015/04/02 08:35:56, Sergiy Byelozyorov wrote: > > > > > > > > On 2015/04/01 23:52:19, Sam Clegg wrote: > > > > > > > > > On 2015/04/01 23:50:41, I haz the power (commit-bot) wrote: > > > > > > > > > > Try jobs failed on following builders: > > > > > > > > > > naclports-linux-pnacl-4 on tryserver.nacl (JOB_FAILED, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-pnacl-4/b...) > > > > > > > > > > > > > > > > > > Looks like that patch failed to apply... > > > > > > > > > > > > > > > > Sorry, I haven't had time to look at this yesterday. I will try to > > > find > > > > > tume > > > > > > > > later today. > > > > > > > > > > > > > > Indeed looks like a patch failure. Can you please verify that the > > patch > > > > > still > > > > > > > applies? > > > > > > > > > > > > Running "./make_all.sh nettle" correctly builds the target for all > nacl > > > > > > platforms. I am on the newest version of the nacl_sdk. Do you have any > > > idea > > > > > what > > > > > > could be going wrong here? > > > > > > > > > > I know very little about nacports to tell what "nettle" or "make_all.sh" > > is. > > > > > What I see from this log > > > > > > > > > > > > > > > (http://build.chromium.org/p/tryserver.nacl/builders/naclports-linux-clang-4/b...) > > > > > is that the patch from this CL (presumably) does not apply to the > source, > > > > which > > > > > is downloaded from > > > > > http://storage.googleapis.com/naclports/mirror/nettle-2.7.tar.gz. The > log > > > > > actually prints all commands, so you can run them locally to reproduce. > > Most > > > > > likely you need to rebase your code. > > > > > > > > Hm. This is strange. I tried to reproduce it and it applied just fine. > I've > > > only > > > > then realized that this patch is only adding new files, so there can't be > > any > > > > conflicts. This means that step 'clang-newlib nettle' gets the patch from > > > > somewhere else. > > > > > > yes, the patch in question is the 'nacl.patch' which is part of the CL... a > > > patch within a patch if you like. > > > > > > Can you try "rm -rf out/build/nettle".. then "make nettle F=1 V=1". > > > > ... > > Build complete [took 16s] > > > > It seems that worked. > > Hmm.. looks like the patch requires some fuzzing to apply. Could be difference > between the git versions we are running. Can you try running 'naclports > updatepatch nettle' and then re-upload? Ok. Done.
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
The patchset sent to the CQ was uploaded after l-g-t-m from sbc@chromium.org Link to the patchset: https://codereview.chromium.org/953493002/#ps160001 (title: "updated patch")
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/160001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/160001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/160001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/160001
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/160001
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/160001
The CQ bit was unchecked by commit-bot@chromium.org
This issue passed the CQ dry run.
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953493002/160001
Message was sent while issue was closed.
Committed patchset #7 (id:160001) as https://chromium.googlesource.com/external/naclports/+/e251f3712daa04222238ae... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
