Report promise error-context strings to GA.

Report Promise error-context strings to GA.

Cleanup log record formatting (added missing spaces, remove redundant info).
Move machine id to from of log file names so they read better (really).

BUG=460614
TEST=None  // Well, you can start import, then yank the card to see if you can't force an error to happen, then check the network tab to see that a GA "exception" was sent with JUST the static error-context string from the related promise.

Committed: https://crrev.com/15a10b61c1b5e031e627803bd0580e85069da2d4
Cr-Commit-Position: refs/heads/master@{#317833}

[Steve McKay, 2015-02-23 20:20:51]

smckay@chromium.org changed reviewers:
+ mtomasz@chromium.org

[mtomasz, 2015-02-24 02:07:04]

lgtm with 2 nits.

https://codereview.chromium.org/953483003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/953483003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/importer_common.js:673:
tracker.sendException(context, false);
nit: Can we add a /* argument_name */? for this false? I have no idea what is
stands for.

https://codereview.chromium.org/953483003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/importer_common.js:695: reportContext();
nit: How about simply calling this.reportErrorContext_(context) here? The
temporary variable seems unnecessary.

[Steve McKay, 2015-02-24 02:44:26]

Respond to review comments.

[Steve McKay, 2015-02-24 02:44:31]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-02-24 02:44:32]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/953483003/#ps40001 (title:
"Respond to review comments.")

[Steve McKay, 2015-02-24 02:44:39]

Dones. Thanks.

https://codereview.chromium.org/953483003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/importer_common.js (right):

https://codereview.chromium.org/953483003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/importer_common.js:673:
tracker.sendException(context, false);
On 2015/02/24 02:07:04, mtomasz wrote:
> nit: Can we add a /* argument_name */? for this false? I have no idea what is
> stands for.

Done.

https://codereview.chromium.org/953483003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/importer_common.js:695: reportContext();
On 2015/02/24 02:07:04, mtomasz wrote:
> nit: How about simply calling this.reportErrorContext_(context) here? The
> temporary variable seems unnecessary.

Done. I was being overly cautious...moving the definition out of the method that
had access to error specifics....as a privacy guard.

[commit-bot: I haz the power, 2015-02-24 02:45:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/953483003/40001

[commit-bot: I haz the power, 2015-02-24 06:12:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-24 06:12:29]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Steve McKay, 2015-02-24 17:49:10]

Undo small, but unnecessary refactoring. Fix broken test.

[Steve McKay, 2015-02-24 17:51:15]

self review

[Steve McKay, 2015-02-24 17:51:18]

The CQ bit was checked by smckay@chromium.org

[Steve McKay, 2015-02-24 17:51:19]

The patchset sent to the CQ was uploaded after l-g-t-m from mtomasz@chromium.org
Link to the patchset: https://codereview.chromium.org/953483003/#ps80001 (title:
"self review")

[commit-bot: I haz the power, 2015-02-24 17:53:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/953483003/80001

[commit-bot: I haz the power, 2015-02-24 18:25:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-02-24 18:33:53]

Patchset 5 (id:??) landed as
https://crrev.com/15a10b61c1b5e031e627803bd0580e85069da2d4
Cr-Commit-Position: refs/heads/master@{#317833}