Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: Source/bindings/templates/interface_base.cpp

Issue 953473002: bindings: Supports [Replaceable] accessors. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/templates/interface_base.cpp
diff --git a/Source/bindings/templates/interface_base.cpp b/Source/bindings/templates/interface_base.cpp
index b5dce157bc2d5a7edd9433e158a94e916f9d3cb2..71ea5516e54b8fdc019ea7dedab7b337250eda2c 100644
--- a/Source/bindings/templates/interface_base.cpp
+++ b/Source/bindings/templates/interface_base.cpp
@@ -64,7 +64,9 @@ static void (*{{method.name}}MethodForPartialInterface)(const v8::FunctionCallba
{{attribute_getter(attribute, world_suffix)}}
{% endif %}
{{attribute_getter_callback(attribute, world_suffix)}}
-{% if not attribute.is_read_only or attribute.put_forwards %}
+{% if (not attribute.is_read_only or
+ attribute.put_forwards or
+ (attribute.is_replaceable and attribute.is_expose_js_accessors)) %}
{% if not attribute.has_custom_setter %}
{{attribute_setter(attribute, world_suffix)}}
{% endif %}

Powered by Google App Engine
This is Rietveld 408576698