Source/bindings/scripts/v8_interface.py - Issue 953473002: bindings: Supports [Replaceable] accessors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/v8_interface.py

Issue 953473002: bindings: Supports [Replaceable] accessors. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/v8_interface.py

diff --git a/Source/bindings/scripts/v8_interface.py b/Source/bindings/scripts/v8_interface.py

index 981ef3990312733abff06dcc94cd52863db5ddb6..42014a67bee8ae2a74441d116bf63ee8c95c4935 100644

--- a/Source/bindings/scripts/v8_interface.py

+++ b/Source/bindings/scripts/v8_interface.py

@@ -308,7 +308,10 @@ def interface_context(interface):

for attribute in attributes),

'has_conditional_attributes': has_conditional_attributes,

'has_constructor_attributes': any(attribute['constructor_type'] for attribute in attributes),

- 'has_replaceable_attributes': any(attribute['is_replaceable'] for attribute in attributes),

+ 'has_replaceable_attributes': any(

+ attribute['is_replaceable'] and

+ not attribute['is_expose_js_accessors']

+ for attribute in attributes),

})

# Methods