bindings: Supports [Replaceable] accessors.

Source/bindings/scripts/v8_attributes.py

 # Copyright (C) 2013 Google Inc. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
 # copyright notice, this list of conditions and the following disclaimer
@@ skipping 41 matching lines @@
 
     # [CheckSecurity]
     is_check_security_for_node = 'CheckSecurity' in extended_attributes
     if is_check_security_for_node:
         includes.add('bindings/core/v8/BindingSecurity.h')
     # [CustomElementCallbacks], [Reflect]
     is_custom_element_callbacks = 'CustomElementCallbacks' in extended_attributes
     is_reflect = 'Reflect' in extended_attributes
     if is_custom_element_callbacks or is_reflect:
         includes.add('core/dom/custom/CustomElementProcessingStack.h')
-    # [PerWorldBindings]
-    if 'PerWorldBindings' in extended_attributes:
-        assert idl_type.is_wrapper_type or 'LogActivity' in extended_attributes, '[PerWorldBindings] should only be used with wrapper types: %s.%s' % (interface.name, attribute.name)
+    # [ExposeJSAccessors]
+    is_expose_js_accessors = 'ExposeJSAccessors' in extended_attributes
     # [ImplementedInPrivateScript]
     is_implemented_in_private_script = 'ImplementedInPrivateScript' in extended_attributes
     if is_implemented_in_private_script:
         includes.add('bindings/core/v8/PrivateScriptRunner.h')
         includes.add('core/frame/LocalFrame.h')
         includes.add('platform/ScriptForbiddenScope.h')
-
     # [OnlyExposedToPrivateScript]
     is_only_exposed_to_private_script = 'OnlyExposedToPrivateScript' in extended_attributes
+    # [PerWorldBindings]
+    if 'PerWorldBindings' in extended_attributes:
+        assert idl_type.is_wrapper_type or 'LogActivity' in extended_attributes, '[PerWorldBindings] should only be used with wrapper types: %s.%s' % (interface.name, attribute.name)
 
     if (base_idl_type == 'EventHandler' and
         interface.name in ['Window', 'WorkerGlobalScope'] and
         attribute.name == 'onerror'):
         includes.add('bindings/core/v8/V8ErrorHandler.h')
 
     context = {
         'access_control_list': access_control_list(interface, attribute),
         'activity_logging_world_list_for_getter': v8_utilities.activity_logging_world_list(attribute, 'Getter'),  # [ActivityLogging]
         'activity_logging_world_list_for_setter': v8_utilities.activity_logging_world_list(attribute, 'Setter'),  # [ActivityLogging]
@@ skipping 10 matching lines @@
         'enum_validation_expression': idl_type.enum_validation_expression,
         'exposed_test': v8_utilities.exposed(attribute, interface),  # [Exposed]
         'has_custom_getter': has_custom_getter(attribute),
         'has_custom_setter': has_custom_setter(attribute),
         'has_side_effect_on_get': 'HasSideEffectOnGet' in extended_attributes,
         'idl_type': str(idl_type),  # need trailing [] on array for Dictionary::ConversionContext::setConversionType
         'is_call_with_execution_context': v8_utilities.has_extended_attribute_value(attribute, 'CallWith', 'ExecutionContext'),
         'is_call_with_script_state': v8_utilities.has_extended_attribute_value(attribute, 'CallWith', 'ScriptState'),
         'is_check_security_for_node': is_check_security_for_node,
         'is_custom_element_callbacks': is_custom_element_callbacks,
-        'is_expose_js_accessors': 'ExposeJSAccessors' in extended_attributes,
+        'is_expose_js_accessors': is_expose_js_accessors,
         'is_getter_raises_exception':  # [RaisesException]
             'RaisesException' in extended_attributes and
             extended_attributes['RaisesException'] in (None, 'Getter'),
         'is_implemented_in_private_script': is_implemented_in_private_script,
         'is_initialized_by_event_constructor':
             'InitializedByEventConstructor' in extended_attributes,
         'is_keep_alive_for_gc': is_keep_alive_for_gc(interface, attribute),
         'is_nullable': idl_type.is_nullable,
         'is_explicit_nullable': idl_type.is_explicit_nullable,
         'is_partial_interface_member':
@@ skipping 12 matching lines @@
         'per_context_enabled_function': v8_utilities.per_context_enabled_function_name(attribute),  # [PerContextEnabled]
         'private_script_v8_value_to_local_cpp_value': idl_type.v8_value_to_local_cpp_value(
             extended_attributes, 'v8Value', 'cppValue', isolate='scriptState->isolate()', used_in_private_script=True),
         'property_attributes': property_attributes(interface, attribute),
         'put_forwards': 'PutForwards' in extended_attributes,
         'reflect_empty': extended_attributes.get('ReflectEmpty'),
         'reflect_invalid': extended_attributes.get('ReflectInvalid', ''),
         'reflect_missing': extended_attributes.get('ReflectMissing'),
         'reflect_only': extended_attribute_value_as_list(attribute, 'ReflectOnly'),
         'runtime_enabled_function': v8_utilities.runtime_enabled_function_name(attribute),  # [RuntimeEnabled]
-        'setter_callback': setter_callback_name(interface, attribute),
+        'setter_callback': setter_callback_name(interface, attribute, is_expose_js_accessors),
         'should_be_exposed_to_script': not (is_implemented_in_private_script and is_only_exposed_to_private_script),
         'world_suffixes': ['', 'ForMainWorld']
                           if 'PerWorldBindings' in extended_attributes
                           else [''],  # [PerWorldBindings]
     }
 
     if is_constructor_attribute(attribute):
         constructor_getter_context(interface, attribute, context)
         return context
     if not has_custom_getter(attribute):
@@ skipping 272 matching lines @@
     else:
         namespace = 'HTMLNames'
     includes.add('core/%s.h' % namespace)
     return '%s::%sAttr' % (namespace, content_attribute_name)
 
 
 ################################################################################
 # Attribute configuration
 ################################################################################
 
-# [Replaceable]
-def setter_callback_name(interface, attribute):
+# [PutForwards], [Replaceable]
+def setter_callback_name(interface, attribute, is_expose_js_accessors):
     cpp_class_name = cpp_name(interface)
     cpp_class_name_or_partial = cpp_name_or_partial(interface)
 
     extended_attributes = attribute.extended_attributes
-    if (('Replaceable' in extended_attributes and
-         'PutForwards' not in extended_attributes) or
-        is_constructor_attribute(attribute)):
+    if (not is_expose_js_accessors and
+        ('Replaceable' in extended_attributes or

[haraken, 2015/02/23 14:48:52]

Why can we remove "'PutForwards' not in extended_attributes" ?

[Yuki, 2015/02/23 15:18:42]

[Replaceable] and [PutForwards] conflict each other, and I assume that both of
them are never sepecified at a time.  Validation of IDLs should be done
somewhere else.

[haraken, 2015/02/23 17:34:00]

Sounds like a good idea.

+         is_constructor_attribute(attribute))):
         return '%sV8Internal::%sForceSetAttributeOnThisCallback' % (

[haraken, 2015/02/23 14:48:52]

Help me understand: What's a difference between a [Replaceable] attribute on a
prototype chain and a [Replaceable] attribute on an instance? I'm wondering why
you don't need to call ForceSet for a [Replaceable] attribute on a prototype
chain.

[Yuki, 2015/02/23 15:18:42]

Basically we have the same implementation for "replaceable on prototype" and
"replaceable on instance".  We call v8::Object::ForceSet to set an own property
in either case.

The point is that
a) for accessor version, the callback function takes only
v8::FunctionCallbackInfo, and there is no way to tell the property name from the
argument.  So, in this CL, we're going to create
  %sAttributeSetterCallback(v8::FunctionCallbackInfo)
where we can tell the property name as "{{attribute.name}}".

b) for attribute (non-accessor) version, the callback function takes two
arguments: property name as v8::String and the v8::PropertyCallbackInfo.  So we
can re-use the same function, named %sForceSetAttributeOnThisCallback, for each
property.

[haraken, 2015/02/23 17:33:59]

Ah, now I understand what this CL is doing :)

It seems a bit confusing to me to use different names between attributes on
prototype chains and attributes on instances. Can we use the same method name?

For example, what happens if we just remove the if branch at line 437 ? (What
happens if we unconditionally use '%sV8Internal::%sAttributeSetterCallback'?)

At the very least, by using the same method name for attributes on prototype
chains and attributes on instances, I guess we can remove a bunch of
'is_expose_js_accessors' checks from this CL, because we no longer need to
distinguish the two methods.

[Yuki, 2015/02/25 14:19:29]

Done.

             cpp_class_name_or_partial, cpp_class_name)
-    if attribute.is_read_only and 'PutForwards' not in extended_attributes:
+    if (attribute.is_read_only and
+            'PutForwards' not in extended_attributes and
+            'Replaceable' not in extended_attributes):

[haraken, 2015/02/23 14:48:52]

Fix indentation.

[Yuki, 2015/02/23 15:18:42]

We need this indentation.  Otherwise, I got a lint warning:
"visually indented line with same indent as next logical line".

I followed this way:
http://stackoverflow.com/questions/21592569/how-to-use-continuation-line-over...

         return '0'
     return '%sV8Internal::%sAttributeSetterCallback' % (cpp_class_name_or_partial, attribute.name)
 
 
 # [DoNotCheckSecurity], [Unforgeable]
 def access_control_list(interface, attribute):
     extended_attributes = attribute.extended_attributes
     access_control = []
     if 'DoNotCheckSecurity' in extended_attributes:
         do_not_check_security = extended_attributes['DoNotCheckSecurity']
@@ skipping 46 matching lines @@
     lambda self: strip_suffix(self.base_type, 'Constructor'))
 
 
 def is_constructor_attribute(attribute):
     # FIXME: replace this with [ConstructorAttribute] extended attribute
     return attribute.idl_type.name.endswith('Constructor')
 
 
 def constructor_getter_context(interface, attribute, context):
     context['needs_constructor_getter_callback'] = context['measure_as'] or context['deprecate_as']