Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: third_party/libexif/BUILD.gn

Issue 953463003: Reland #317760 - add gn_all, gyp_all targets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: do not try to remove views_unittests on android Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/libaddressinput/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/libexif/BUILD.gn
diff --git a/third_party/libexif/BUILD.gn b/third_party/libexif/BUILD.gn
index be8caf6ff16bb37bf43f9bc424d8bb7c2e2ad28b..de9b2ef724ccf26788715000c2fa9461c4a932b4 100644
--- a/third_party/libexif/BUILD.gn
+++ b/third_party/libexif/BUILD.gn
@@ -4,10 +4,19 @@
# Linux should use system libexif
if (!is_linux || is_chromeos) {
-
# TODO(thestig): Properly support building on Linux.
config("libexif_config") {
include_dirs = [ "sources" ]
+ if (is_clang) {
+ cflags = [
+ "-Wno-enum-conversion",
+ "-Wno-switch",
+ "-Wno-format",
+
+ # libexif uses fabs(int) to cast to float.
+ "-Wno-absolute-value",
+ ]
+ }
}
static_library("libexif") {
@@ -51,9 +60,7 @@ if (!is_linux || is_chromeos) {
ldflags = [ "/DEF:" + rebase_path("libexif.def") ]
- cflags = [
- "/wd4018", # size/unsigned mismatch
- ]
+ cflags = [ "/wd4018" ] # size/unsigned mismatch
# TODO(GYP): Handle /analyze switch, when it will be used in GN.
} else if (is_linux) {
« no previous file with comments | « third_party/libaddressinput/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698