Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 953463003: Reland #317760 - add gn_all, gyp_all targets (Closed)

Created:
5 years, 10 months ago by Dirk Pranke
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland #317760 - add gn_all, gyp_all targets In order to be able to make sure we are building the same list of targets in both the GYP and GN builds, this patch adds new 'gn_all' and 'gyp_all' targets. Eventually, we should make sure that if one builds 'gn_all', then building 'gyp_all', 'All', or 'all' then has nothing to do. We're not there yet, but this is a start. The 'gn_all' target replaces the //:root target in the GN builds. TBR=brettw@chromium.org BUG=461019 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/e2ef382dd208417056acbd579620a428fa1b7af4 Cr-Commit-Position: refs/heads/master@{#317893}

Patch Set 1 #

Patch Set 2 : fix aura and ozone targets #

Patch Set 3 : do not try to remove views_unittests on android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+394 lines, -237 lines) Patch
M BUILD.gn View 1 2 3 chunks +206 lines, -224 lines 0 comments Download
M build/all.gyp View 1 1 chunk +152 lines, -1 line 0 comments Download
M build/secondary/tools/grit/grit_rule.gni View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 4 chunks +6 lines, -7 lines 0 comments Download
M components/pdf/renderer/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/libaddressinput/BUILD.gn View 3 chunks +12 lines, -1 line 0 comments Download
M third_party/libexif/BUILD.gn View 2 chunks +11 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
The fix is to remove views_unittests and wm_unittests on the Mac builds, as well as ...
5 years, 10 months ago (2015-02-24 19:33:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953463003/20001
5 years, 10 months ago (2015-02-24 19:34:34 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_dbg/builds/45933)
5 years, 10 months ago (2015-02-24 19:56:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953463003/40001
5 years, 10 months ago (2015-02-24 20:20:36 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-24 21:42:31 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-24 21:43:17 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/e2ef382dd208417056acbd579620a428fa1b7af4
Cr-Commit-Position: refs/heads/master@{#317893}

Powered by Google App Engine
This is Rietveld 408576698