Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Unified Diff: src/factory.cc

Issue 953463002: Reland "Correctly propagate terminate exception in TryCall." (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: addressed comments Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/execution.cc ('k') | test/cctest/test-thread-termination.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/factory.cc
diff --git a/src/factory.cc b/src/factory.cc
index a07d656d75f923dd94c891a0d5d1fe53244ca789..d823f5836631cc76b7d4dbaf0911a94c6ecc4fc7 100644
--- a/src/factory.cc
+++ b/src/factory.cc
@@ -1195,7 +1195,9 @@ MaybeHandle<Object> Factory::NewError(const char* maker, const char* message,
arraysize(argv),
argv,
&exception).ToHandle(&result)) {
- return exception;
+ Handle<Object> exception_obj;
+ if (exception.ToHandle(&exception_obj)) return exception_obj;
+ return undefined_value();
}
return result;
}
@@ -1222,7 +1224,9 @@ MaybeHandle<Object> Factory::NewError(const char* constructor,
arraysize(argv),
argv,
&exception).ToHandle(&result)) {
- return exception;
+ Handle<Object> exception_obj;
+ if (exception.ToHandle(&exception_obj)) return exception_obj;
+ return undefined_value();
}
return result;
}
« no previous file with comments | « src/execution.cc ('k') | test/cctest/test-thread-termination.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698