Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 953423003: Push API: Workaround for GCM lowercasing subtypes (Closed)

Created:
5 years, 10 months ago by johnme
Modified:
5 years, 10 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Push API: Workaround for GCM lowercasing subtypes Temporary workaround for a bug in GCM where it converts subtypes to lowercase. BUG=461867 Committed: https://crrev.com/8cd63f8bbe79dc47df8ddf60b8c9e09d0e96ca42 Cr-Commit-Position: refs/heads/master@{#318102}

Patch Set 1 #

Patch Set 2 : Add crbug.com/461867 to TODO #

Patch Set 3 : StringToUpperASCII isn't in base #

Patch Set 4 : Don't uppercase the leading "wp:" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chrome/browser/services/gcm/push_messaging_application_id.cc View 1 2 3 3 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Michael van Ouwerkerk
lgtm please add a bug number to the description and the todo
5 years, 10 months ago (2015-02-25 18:08:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953423003/40001
5 years, 10 months ago (2015-02-25 18:15:51 UTC) #5
johnme
Heads up: patch changed quite a bit while fixing trybots.
5 years, 10 months ago (2015-02-25 19:08:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953423003/60001
5 years, 10 months ago (2015-02-25 19:09:04 UTC) #9
Michael van Ouwerkerk
still lgtm
5 years, 10 months ago (2015-02-25 19:09:34 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 10 months ago (2015-02-25 20:23:50 UTC) #11
commit-bot: I haz the power
5 years, 10 months ago (2015-02-25 20:24:39 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/8cd63f8bbe79dc47df8ddf60b8c9e09d0e96ca42
Cr-Commit-Position: refs/heads/master@{#318102}

Powered by Google App Engine
This is Rietveld 408576698