Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 953363003: Figure out the default graphics card on the Browser process (Closed)

Created:
5 years, 9 months ago by dnicoara
Modified:
5 years, 9 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@assume-minigbm
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Figure out the default graphics card on the Browser process For platforms where /dev/dri/card0 isn't the default card we need to figure what the default is on the Browser side so we can ignore hotplug events for it. BUG=427959 TEST=Ran on link freon Committed: https://crrev.com/cffafa68fd095a3da6a8d058ec3eecca0cb19682 Cr-Commit-Position: refs/heads/master@{#318091}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M ui/ozone/platform/dri/dri_util.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_util.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.h View 3 chunks +8 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/native_display_delegate_proxy.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_dri.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ui/ozone/platform/dri/ozone_platform_gbm.cc View 1 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
dnicoara
PTAL I need my head shrunk. Tracing indicates that aura::Env is initialized early enough that ...
5 years, 9 months ago (2015-02-25 17:18:50 UTC) #2
alexst (slow to review)
lgtm https://codereview.chromium.org/953363003/diff/1/ui/ozone/platform/dri/ozone_platform_gbm.cc File ui/ozone/platform/dri/ozone_platform_gbm.cc (right): https://codereview.chromium.org/953363003/diff/1/ui/ozone/platform/dri/ozone_platform_gbm.cc#newcode150 ui/ozone/platform/dri/ozone_platform_gbm.cc:150: primary_graphics_card_path_ = GetFirstDisplayCardPath(); GetPrimaryDsiplayCardPath for consistency? I know ...
5 years, 9 months ago (2015-02-25 18:54:51 UTC) #3
dnicoara
https://codereview.chromium.org/953363003/diff/1/ui/ozone/platform/dri/ozone_platform_gbm.cc File ui/ozone/platform/dri/ozone_platform_gbm.cc (right): https://codereview.chromium.org/953363003/diff/1/ui/ozone/platform/dri/ozone_platform_gbm.cc#newcode150 ui/ozone/platform/dri/ozone_platform_gbm.cc:150: primary_graphics_card_path_ = GetFirstDisplayCardPath(); On 2015/02/25 18:54:50, alexst wrote: > ...
5 years, 9 months ago (2015-02-25 19:03:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/953363003/20001
5 years, 9 months ago (2015-02-25 19:03:57 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-02-25 19:49:36 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-02-25 19:50:45 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cffafa68fd095a3da6a8d058ec3eecca0cb19682
Cr-Commit-Position: refs/heads/master@{#318091}

Powered by Google App Engine
This is Rietveld 408576698